Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp174891ybb; Thu, 9 Apr 2020 20:18:25 -0700 (PDT) X-Google-Smtp-Source: APiQypLZlPZg8vYqKzd9T4VaxGE3HzpvP9NphhyTzjaDiGkH9H2oDmIEkLei1zVcayKXnMDisXYs X-Received: by 2002:ac8:f27:: with SMTP id e36mr2575660qtk.67.1586488705570; Thu, 09 Apr 2020 20:18:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586488705; cv=none; d=google.com; s=arc-20160816; b=Bj2MzCORmYT2CZ2gn/UMiU7FLU0yQtP/OastAqq7xkmw8nbH8sUNtmtBJCYSLxWamB 6BygbBtEqnYfZWSZN2fTq/LFfbYyI8CqlPk8mIIe6kCKI8gGmlXFWaKU+6bCFKrk1Yza dzeeQA9PAxKRtvkCLvq76xu4PdSAZUVqlgQ/FzRtoGnEa5lgBtyludWFbiv1bieVEjUb YzrBeFm2VpgY0qRBbbpxd8BfFVZc1M/lmJNOrJ7tiQM04PH+n+ILGlgUiqclDxRTkm98 Bi10HjjjsqTcjw+b32Kmkc7/n3y7DqvQc0DKHmYF8jNKFLbHzaNgP2hbImXNnEPBcggr D2aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=AzZTM/QOXa3cEWuAKWQaMbWvYzXx9wd2FBSqerQOajc=; b=iyNz5q0QtQ1XyzLLe20r+qfcyMKOCX+Chz9m9WsK1y+2a0x9HVIuym4HDkuJQcWPgq YaFIfLeNQhfBlLK3PQ5wvov7/veUIID432KwGU2W9QkB24YT3qkClzdDmQTNHVMh+tzy zISCYfM86+mLzuo0K7Oji+4iwigbH5kInqjk4WlztxBrwrwO+/qwLWLIGfMzSBCA0GjK 3FNW1vd8lDO8R/nKC7EYg7T3dMpm5rIUFqoApehtFXU+gZtP7cbxVLNRo++vVTTHju51 zBeDGqJwJrnjwhgPf242bJa1njLIGsGHoLPA3jUOprIipJrYhU936nacVA6jQUH1hW2v b2Fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p97si341228qvp.168.2020.04.09.20.18.04; Thu, 09 Apr 2020 20:18:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbgDJDRy (ORCPT + 99 others); Thu, 9 Apr 2020 23:17:54 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:55472 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726598AbgDJDRy (ORCPT ); Thu, 9 Apr 2020 23:17:54 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 03A3HROM029851 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Apr 2020 23:17:27 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id F21C842013D; Thu, 9 Apr 2020 23:17:26 -0400 (EDT) Date: Thu, 9 Apr 2020 23:17:26 -0400 From: "Theodore Y. Ts'o" To: yangerkun Cc: jack@suse.com, linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: using matching invalidatepage in ext4_writepage Message-ID: <20200410031726.GH45598@mit.edu> References: <20200226041002.13914-1-yangerkun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226041002.13914-1-yangerkun@huawei.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Feb 26, 2020 at 12:10:02PM +0800, yangerkun wrote: > Run generic/388 with journal data mode sometimes may trigger the warning > in ext4_invalidatepage. Actually, we should use the matching invalidatepage > in ext4_writepage. > > Signed-off-by: yangerkun Applied, thanks. Apologies for overlooking this patch earlier. - Ted