Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp194807ybb; Thu, 9 Apr 2020 20:54:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKa6mHypGjyPpVqcU6PjKDP62in7iwxrV8RTp7enWgR82HGh2xbUxdS0gGsEnM3kaj6JRai X-Received: by 2002:a37:624d:: with SMTP id w74mr2286749qkb.172.1586490860954; Thu, 09 Apr 2020 20:54:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586490860; cv=none; d=google.com; s=arc-20160816; b=wS4+ZaJWHDLdsCsXBzknVLsfHLXIfTPiic9q233Ow7O2cxxQJGz7DPRrO1DGOA0bQa CR9LBBj7+qjv+S93kzR5YwpBenRmrbMrn3elYruGhaz2/5X41sHzdwCOaiRAJRfD+Ws6 SsPiRVGXF2b6BWCgmSHtlPvI+EWDpapNURDedfklmIChKH5Df10elu/AKv/Tz/3QFBR3 DbMtWyFV6JrxSt3k9FApz0m3Hbv9Corf+AW0i7ocnm1uYJuBs06VAxR9XWEh6Q2WUMPc Uv0DNPOps5njitLK+SvAV3xoKgPKnJ4BY1KPNHzysEqBBEE3u2/xM8ciLgnTT34ySc/w Kgfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=nuSPvlFcAJ8p4CeZxLUuD/1RtkICy7UX83tOMr1sif4=; b=Qqeu+eohw8zp8PujvMd9zOvXDbo5jmfMLsXbOgp5NnFbjwMY3luv8EXlHEdAFJBEbo dUrt03PpV6ecrsm6YDnGfB3uvgz4pPebkX87dVgvHEhbXAW/qCLO5WCtyv+NQa6Crfhn N0JkPeww/1oy4FIdieZkCK/FQD/xG/s6SZ3C3k+pfiH5AERI2knCTlKUdMdhwt9ekipx mKohGfqiF5nZ6nrJTuLOMcZKdm/LsqIQ4EmHt0e5vX+0TJxhojzzb1VM5Efwzfw7jpDn xaNuznqcgwzpnHHECr8ebgPDr0qy2vl3UboKxKfV+pT/aPg9Ej2D1BrpbVJCXaMErdkr HDOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14si474133qtv.181.2020.04.09.20.54.00; Thu, 09 Apr 2020 20:54:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728937AbgDJDwk (ORCPT + 99 others); Thu, 9 Apr 2020 23:52:40 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:58928 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728547AbgDJDwk (ORCPT ); Thu, 9 Apr 2020 23:52:40 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 03A3qZKW005022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Apr 2020 23:52:36 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id BB72E42013D; Thu, 9 Apr 2020 23:52:35 -0400 (EDT) Date: Thu, 9 Apr 2020 23:52:35 -0400 From: "Theodore Y. Ts'o" To: Jan Kara Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/2] ext2fs: Fix error checking in dx_link() Message-ID: <20200410035235.GK45598@mit.edu> References: <20200330090932.29445-1-jack@suse.cz> <20200330090932.29445-2-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330090932.29445-2-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Mar 30, 2020 at 11:09:31AM +0200, Jan Kara wrote: > dx_lookup() uses errcode_t return values. As such anything non-zero is > an error, not values less than zero. Fix the error checking to avoid > crashes on corrupted filesystems. > > Signed-off-by: Jan Kara Applied, thanks. - Ted