Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp196294ybb; Thu, 9 Apr 2020 20:56:47 -0700 (PDT) X-Google-Smtp-Source: APiQypIo+QoOWH3RmEOgHVGCrcL/GigmIihGV6NyRO6rpx26mwk8iI9ooxncJlNhJqiN2s4SmZVb X-Received: by 2002:a37:49c7:: with SMTP id w190mr2252071qka.402.1586491007049; Thu, 09 Apr 2020 20:56:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586491007; cv=none; d=google.com; s=arc-20160816; b=yUe5N5/0tUxDXQrJqu2Dh/Leexf1u++oAvg++GXAVPfInTc+cQud99qEfDCW6F5Uqs aQG/fDYOsC08mEnurR1C6gNvy2bNqMK3l7Z2G5ht2SvNzK2VbqjgnAugUPkB1ytSLnjn 9R6tdDBB0Wd5UXD026Pp84IDFV48kixUBYT3zZDeUaMXedyPglEpOK5GtDCknV+TFCS1 a5mMBeFAb7pNYqb3Zy+SAo7A8sRLtmQYGPY1PmDW883dW2eMrJPBvu0LmvzIg9LYeIV9 C2r+c4GStazS9KpT6PiAfF3wBQljlqUbCfr2F/4nvweQccFdO1X4dUMgYsFF5BOzAvIe Z0Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=8bSpXwcOBy5TukzFGHKBIRkOywadS7tfv9z2Kr6PfjQ=; b=sj0jMvNIaCM46fRi0sKM4OrYEonCtpmFuhM7OG4+wscr5BzGoLmC7WBH22DsS1TGnd MzkewLi1jRA/BQ4miwN1rzOsZgPp2xJCu076CB1LOZzFxkYYLnZKNDCKVlVx/WP+6XmQ OXPdGCpCPpHx1wasDcjgmOYLqjCpLC9zUvXBYSVk9QpmUh6/3urB6w8HhO2ck6wGdstx 6s6c9zxgI4E39/agOqhNiEbWqxMD7Y0XWfV+iiPXCcJgUR8Nd7/AHoCAn3sdjAnT1tWv kJl6dCN/qs9x/qmRr/NmWQyTJTHHYnZ8AfbCRXRYq/jU964VIld414meFZyAG17fUo6L mbUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j31si479754qtd.68.2020.04.09.20.56.32; Thu, 09 Apr 2020 20:56:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728609AbgDJDtk (ORCPT + 99 others); Thu, 9 Apr 2020 23:49:40 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:58625 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728600AbgDJDtk (ORCPT ); Thu, 9 Apr 2020 23:49:40 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 03A3nXpv004315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Apr 2020 23:49:34 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 96D8B42013D; Thu, 9 Apr 2020 23:49:33 -0400 (EDT) Date: Thu, 9 Apr 2020 23:49:33 -0400 From: "Theodore Y. Ts'o" To: Josh Triplett Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Fix return-value types in several function documentation comments Message-ID: <20200410034933.GJ45598@mit.edu> References: <60a3f4996f4932c45515aaa6b75ca42f2a78ec9b.1585512514.git.josh@joshtriplett.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60a3f4996f4932c45515aaa6b75ca42f2a78ec9b.1585512514.git.josh@joshtriplett.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Mar 29, 2020 at 01:21:41PM -0700, Josh Triplett wrote: > The documentation comments for ext4_read_block_bitmap_nowait and > ext4_read_inode_bitmap describe them as returning NULL on error, but > they return an ERR_PTR on error; update the documentation to match. > > The documentation comment for ext4_wait_block_bitmap describes it as > returning 1 on error, but it returns -errno on error; update the > documentation to match. > > Signed-off-by: Josh Triplett Applied, thanks. - Ted