Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp219116ybb; Thu, 9 Apr 2020 21:32:48 -0700 (PDT) X-Google-Smtp-Source: APiQypIQ3snLa2bI3AVWuwfOlFg39Lj7UK7vaN1jWZ911nGcm88CRCwnUlXqKJZYJ/3jci7Pac3d X-Received: by 2002:aed:2be5:: with SMTP id e92mr2855945qtd.374.1586493168396; Thu, 09 Apr 2020 21:32:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586493168; cv=none; d=google.com; s=arc-20160816; b=G5ShbQFw8sR/3kZx4PnxOjG6jbJBHpgfS5A95yVBpYCZVKBaZc/Pw0fmiCYWTJlg9n 4gn6SY1cjqLVnkgYD75CQ/r8XdHh2KSXeeiPxb41wefPARIOTiy/sFnYKK1a/Hh+hqjF Y6Bn+BL14GBlRwpUX0PxYVTKvYK4imEIAOFvhx+gQksCTTr5S6L0StItQBn0xYKMQ5mT UmYerSUfHlHJsz9qb7SzR1vLf81pW0gCPgaKWJ6oIuWL2x8ghomFRMh1pzmqHvkLaap3 tNqzZERiyi2ADteJl614AAzmHGjS4ujDfYcMmG/K42kN4fQxWej7ET1nuwPYmCzdgMKL tnSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GHdTcTar8MKeIkhTbzdFFszkXI25PqrnF6BHkfNApP0=; b=xfV+opfLyVqALAHPCWt+VeddEsKe7ijLU5gtdpe07L7X7Zx4rauoV0Dyd5pYf3yb53 //t3+m+Zaw8Wbt1tPmtSwevivmSDBtPty5bCSibAvLofJrHLbgSdLUdceE3KoYoNjp3R svbKl5PnWdLde0MEq6AFdic9pHPBz062Sq7enphLfAUg25/IsFwqIxdHSQaAwBxOdviT jLQh2NN83iNz6uVubkqg1BEQjOaZ6yhoYlkAk5ZVKjiUEfvi/HiZmY2KRQRPjQsGusCB v61JnyW1Tawgu+vBH3x2PaiikLgzPEuU9SHqXQiB142yWzCmfA9zvN9RDXxVbI7DP2N8 0bug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19si513689qta.398.2020.04.09.21.32.19; Thu, 09 Apr 2020 21:32:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725818AbgDJEcR (ORCPT + 99 others); Fri, 10 Apr 2020 00:32:17 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:34567 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725816AbgDJEcR (ORCPT ); Fri, 10 Apr 2020 00:32:17 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 03A4WDZr013368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Apr 2020 00:32:13 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 2B78342013D; Fri, 10 Apr 2020 00:32:13 -0400 (EDT) Date: Fri, 10 Apr 2020 00:32:13 -0400 From: "Theodore Y. Ts'o" To: Jan Kara Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 2/2] ext2fs: Fix off-by-one in dx_grow_tree() Message-ID: <20200410043213.GL45598@mit.edu> References: <20200330090932.29445-1-jack@suse.cz> <20200330090932.29445-3-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330090932.29445-3-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Mar 30, 2020 at 11:09:32AM +0200, Jan Kara wrote: > There is an off-by-one error in dx_grow_tree() when checking whether we > can add another level to the tree. Thus we can grow tree too much > leading to possible crashes in the library or corrupted filesystem. Fix > the bug. > > Signed-off-by: Jan Kara Applied, thanks. - Ted