Received-SPF: neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-ext4-owner@vger.kernel.org) client-ip=209.132.180.67;
Subject: Re: [PATCH] ext4: remove unnecessary test_opt for DIOREAD_NOLOCK
To:     xiakaixu1987@gmail.com, linux-ext4@vger.kernel.org
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        Kaixu Xia <kaixuxia@tencent.com>
References: <1586751862-19437-1-git-send-email-kaixuxia@tencent.com>
From:   Ritesh Harjani <riteshh@linux.ibm.com>
Date:   Mon, 13 Apr 2020 10:08:12 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <1586751862-19437-1-git-send-email-kaixuxia@tencent.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <20200413043813.4FA0F4C058@d06av22.portsmouth.uk.ibm.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


On 4/13/20 9:54 AM, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> The DIOREAD_NOLOCK flag has been cleared when doing the test_opt
> that is meaningless, so remove the unnecessary test_opt for DIOREAD_NOLOCK.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Make sense.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>


> ---
>   fs/ext4/super.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9728e7b0e84f..855874ea4b29 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3973,17 +3973,13 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> 
>   	if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) {
>   		printk_once(KERN_WARNING "EXT4-fs: Warning: mounting with data=journal disables delayed allocation, dioread_nolock, and O_DIRECT support!\n");
> +		/* can't mount with both data=journal and dioread_nolock. */
>   		clear_opt(sb, DIOREAD_NOLOCK);
>   		if (test_opt2(sb, EXPLICIT_DELALLOC)) {
>   			ext4_msg(sb, KERN_ERR, "can't mount with "
>   				 "both data=journal and delalloc");
>   			goto failed_mount;
>   		}
> -		if (test_opt(sb, DIOREAD_NOLOCK)) {
> -			ext4_msg(sb, KERN_ERR, "can't mount with "
> -				 "both data=journal and dioread_nolock");
> -			goto failed_mount;
> -		}
>   		if (test_opt(sb, DAX)) {
>   			ext4_msg(sb, KERN_ERR, "can't mount with "
>   				 "both data=journal and dax");
>