Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200413054419.1560503-1-ira.weiny@intel.com> <CAOQ4uxguVRysAuVEtQmPj+x=RDtDnGCtNeGvbvXNuvppwagwDg@mail.gmail.com>
 <20200413155325.GA1560218@iweiny-DESK2.sc.intel.com>
In-Reply-To: <20200413155325.GA1560218@iweiny-DESK2.sc.intel.com>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Mon, 13 Apr 2020 19:11:46 +0300
Message-ID: <CAOQ4uxg4Cr-vqA35TbhD5q7Jd1OgLUiL48nO_XNhkpMsCDW_UQ@mail.gmail.com>
Subject: Re: [PATCH] xfs/XXX: Add xfs/XXX
To:     Ira Weiny <ira.weiny@intel.com>
Cc:     fstests <fstests@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Chinner <david@fromorbit.com>,
        Christoph Hellwig <hch@lst.de>,
        "Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
        Jeff Moyer <jmoyer@redhat.com>,
        Ext4 <linux-ext4@vger.kernel.org>,
        linux-xfs <linux-xfs@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

> >
> > But the kernel patch suggests that there is an intention to make
> > this behavior also applicable to ext4??
> > If that is the case I would recommend making this a generic tests
> > which requires filesystem support for -o dax=XXX
>
> I have a patch set for ext4 which is not quite passing this.  I'm not sure what
> is going on yet.
>
> Once that is working I was going to move this to generic.  (The documentation
> in the kernel patch set also reflects ext4 being different from xfs for the
> time being.)

IMO, if ext4 maintainer is on board with the plan to make this behavior of
ext4 then it is best to add this test as generic from the start.
Any other filesystems that may tag along later?

>
> This is mainly because I'm not sure if ext4 will make 5.8 or not.  Would you
> prefer making this generic now?  I assume there is some way to mark generic
> tests for a subset of FS's?  I have not figured that out yet.
>

There is a way, _supported_fs, see the tests/shared/*,
but the idea it to get rid of those in favor of feature tests such as
_require_scratch_dax

I believe it should be trivial to implement
_require_scratch_dax_never

Thanks,
Amir.