Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Apr 2020 22:59:14 -0400
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: fix BUG_ON in
 fs/ext4/page_io.c:ext4_release_io_end()
Message-ID: <20200414025914.GE90651@mit.edu>
References: <20200414022842.272657-1-tytso@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200414022842.272657-1-tytso@mit.edu>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 13, 2020 at 10:28:42PM -0400, Theodore Ts'o wrote:
> The function ext4_release_io_end() can be called by
> ext4_put_io_end_defer() with the EXT4_IO_UNWRITTEN flag set and
> io_end->size is 0.  In that case, it's safe to release the io_end
> structure, since if io_end->size is zero, there is no unwritten region
> to release.
> 
> This can be reproduced using generic/300, although not very reliably,
> and almost never using a freshly rebooted kernel.
> 
> Google-Bug-Id: 15054006
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

NACK; this patch no longer applies given the move to use iomap for direct I/O.

      	   	    	   	   	 - Ted