Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp231022ybb; Tue, 14 Apr 2020 23:49:03 -0700 (PDT) X-Google-Smtp-Source: APiQypIBwX0iNW7SIcB1Eoknr0udIHocikodHOXC4cUtJWiqJgM4kGK7EOoqOjzObTQ35q9i7Qxf X-Received: by 2002:a05:6402:1505:: with SMTP id f5mr21371140edw.208.1586933342861; Tue, 14 Apr 2020 23:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586933342; cv=none; d=google.com; s=arc-20160816; b=vu4d46Q5tbWCL2m4b0KgL1Ftw7IEXfICGOXH5hPlZ2chchDkac4xskR2X8k936yKF8 l8R4hD2sYrAu07M9yLxpVcb2oZ7LmzftXESD9LMfoU7BZhU8L+YJvh5vhmfW/9zXz+jP 8jmDfksWHaeU8WKMrVQBEXkL2i4c/v/o3TUJUCEbBh4wEGg56UcQckWLpWmG0X9g0eS0 Zoc2r5ogvty511WeDXS8rcAyLm/ChAutN4J2RuOaTripJAnqMcmg8Eky2A4G75Vxi7x+ qMwrORRfv5FPelPq08UTpnjbL3AXCBOMa98llWSXTDZHRpPlBKFqqCJSuVMtIhjMZOgi BjLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DjdB5K64eyky61W2QTpj3b8q0jOeupS7kvRJzSmx2cA=; b=xqOqf8d0ml/pwcUfHEDsMIZymV+lL6oMrC5niPIzFHeB1dqcbBh8l02xvEbC4CgFmW B6lzKhffIMjSiFnd51zQ0DaQFHu8bVK6tmAAdNxHEexFNTYz3gBH5/m/Clf5ews2n54m s06jFlbmN31ue1PYeIbV5Vs7HJ0188rSnifJZfe3Wi5rzfjQxiZu4io1nW0M1i+ECdwp ovYvZ5BLrHBeM4iRF/6I9nVkSSjJyN1Or4OaX9jyE1UUSrGd3S408RblG9iO17CZm7d1 5Z4D2OSDo8sh8aDJdrt5t4hwTbfyapFM2g/BtJgzPDyHYukkJ2NrHDx68l6XLBnI1/Il QA3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si9745861edk.133.2020.04.14.23.48.26; Tue, 14 Apr 2020 23:49:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728732AbgDNB7O (ORCPT + 99 others); Mon, 13 Apr 2020 21:59:14 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42405 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727867AbgDNB7O (ORCPT ); Mon, 13 Apr 2020 21:59:14 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 03E1x8f5032124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Apr 2020 21:59:09 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 925D042013D; Mon, 13 Apr 2020 21:59:08 -0400 (EDT) Date: Mon, 13 Apr 2020 21:59:08 -0400 From: "Theodore Y. Ts'o" To: Andreas Dilger Cc: Michael Forney , linux-ext4@vger.kernel.org Subject: Re: [PATCH] libext2fs: avoid pointer arithmetic on `void *` Message-ID: <20200414015908.GD90651@mit.edu> References: <20200405045346.21860-1-mforney@mforney.org> <8304797A-1199-45A4-818F-1BBE598C73A6@dilger.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8304797A-1199-45A4-818F-1BBE598C73A6@dilger.ca> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Apr 05, 2020 at 06:43:09PM -0600, Andreas Dilger wrote: > On Apr 4, 2020, at 10:53 PM, Michael Forney wrote: > > > > The pointer operand to the binary `+` operator must be to a complete > > object type. > > > > Signed-off-by: Michael Forney > > Seems straight forward enough. Not needed for GCC, but strictly correct. > > Reviewed-by: Andreas Dilger Applied, thanks. - Ted