Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <E6C93199-73FE-46B0-9001-7D43D4FDEA26@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_A080154A-8C9A-4B39-8C4B-AC6E286C4005";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] ext4: remove redundant variable has_bigalloc in
 ext4_fill_super
Date:   Wed, 15 Apr 2020 12:15:24 -0600
In-Reply-To: <1586935542-29588-1-git-send-email-kaixuxia@tencent.com>
Cc:     linux-ext4 <linux-ext4@vger.kernel.org>,
        Theodore Ts'o <tytso@mit.edu>, Kaixu Xia <kaixuxia@tencent.com>
To:     xiakaixu1987@gmail.com
References: <1586935542-29588-1-git-send-email-kaixuxia@tencent.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_A080154A-8C9A-4B39-8C4B-AC6E286C4005
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Apr 15, 2020, at 1:25 AM, xiakaixu1987@gmail.com wrote:
>=20
> From: Kaixu Xia <kaixuxia@tencent.com>
>=20
> We can use the ext4_has_feature_bigalloc() function directly to check
> bigalloc feature and the variable has_bigalloc is reduncant, so remove
> it.
>=20
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/super.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 855874ea4b29..60bb3991304e 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3681,7 +3681,7 @@ static int ext4_fill_super(struct super_block =
*sb, void *data, int silent)
> 	int blocksize, clustersize;
> 	unsigned int db_count;
> 	unsigned int i;
> -	int needs_recovery, has_huge_files, has_bigalloc;
> +	int needs_recovery, has_huge_files;
> 	__u64 blocks_count;
> 	int err =3D 0;
> 	unsigned int journal_ioprio =3D DEFAULT_JOURNAL_IOPRIO;
> @@ -4196,8 +4196,7 @@ static int ext4_fill_super(struct super_block =
*sb, void *data, int silent)
>=20
> 	/* Handle clustersize */
> 	clustersize =3D BLOCK_SIZE << =
le32_to_cpu(es->s_log_cluster_size);
> -	has_bigalloc =3D ext4_has_feature_bigalloc(sb);
> -	if (has_bigalloc) {
> +	if (ext4_has_feature_bigalloc(sb)) {
> 		if (clustersize < blocksize) {
> 			ext4_msg(sb, KERN_ERR,
> 				 "cluster size (%d) smaller than "
> --
> 2.20.0
>=20


Cheers, Andreas


--Apple-Mail=_A080154A-8C9A-4B39-8C4B-AC6E286C4005
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl6XTz0ACgkQcqXauRfM
H+BZHA/9FHNlLnuk4j9U5nBHaygdAd2D6374Vg8VFHr2MJkv9tDw6MTbn78PJAji
LyaLkkGvqryk7X0B4lys/JzwIOKsGgvHabfWCJ8NLKJOpUKs/nNFEJWN+ZFUleZv
2lBFDGmgf39ZIIXSvs5NtkIQNjKw/9PBliWaHMW242MgnGenfr+C1nt/l7RinbR/
hm006NLNJaLfW1nJ9VCnNzu6RHFT9utZaTSQeCJM9ddqsdO/yeioCs+4l9mM4790
u2/HtKJJf93xcrfBtBK4HKJsnBiGrMd9Oop1l1WPWw7ijK2/Eb84UfChZlNSwURB
/6lp+G97XY8s0wYxdzLyfD8ub5kXSnFUZHBZ1NETQFuJUoFMg9a5+p6N0J5gCmCg
gs6TlGv4parkgbb5+eK00HellQI5T/NFpv632iH6mDO3mE//fHu6SSsRA+ayED9Z
RbwU7EPTMT6JuKSxLtBbgcxAKZmOS9Qb1J6NNEgRRk1fPgU69gZkjKR93tvUVEzI
MmUToEK1haLuyPH4WFqZPCihtlaM5jzeUIKv0FRYHTOPh8rmY9w9zxSLTJJv5PVw
A2mX9hSuQ3rJtpuFwl0LOsVGI1MsbDMkkXdZU4jkmsTvtKv54v03ZRSQbqhsdIRF
c+VmdiqHJLuOB4oT0rPG/bcAnOoBJX/6S+0KfMwp0ohFRo3sBS4=
=/ew3
-----END PGP SIGNATURE-----

--Apple-Mail=_A080154A-8C9A-4B39-8C4B-AC6E286C4005--