Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3217495ybz; Sun, 19 Apr 2020 21:05:13 -0700 (PDT) X-Google-Smtp-Source: APiQypI4HGziVn6vuNym+KLjpY+smeewEOjuA1hG1ub0cUocBjR6YgpGI2mgns5+YfjZldV3lKzv X-Received: by 2002:a05:6402:1c07:: with SMTP id ck7mr12990214edb.202.1587355513174; Sun, 19 Apr 2020 21:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587355513; cv=none; d=google.com; s=arc-20160816; b=ByblsmnBdEJBX10pw4enf8/liOt3QFYN1vR/rD8ayOaVxcUoBr9cCZU+sLdUjbVNEZ Gnp33MeMC6ElYgCbPHJ/bAc8BMOSJUYQJ03qi3YOD4NK51HZ3OOzlvGBlFKCUrA35EzK fdadjtRqjWiw6LmVpMO6SIsp0eT4+tkngJJeTSCYRmZzLUoVFBhKhD1gL96wBq+R5fX5 pYQOu6HOhD3rVAEKHj0wcfbA0Qnk2HdNMEAKRomcWXhSmvZCi0qKhcDDHMtx/+eqmDHz 55tn34JeuLUKEGmv5nVi3M0KXFBCcv9E/Z8fKaWdt3/Y8VZGrOT48G905YvyQqyy9eUU I1Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=pZRboQ5DSWn/3Z2SNT62sqAblqFajaC66/Fv4hTa/N0=; b=asEr8rEaM9/3w2cfsB+Jl94kjuwq1F6zw9rJ6RJJDqirJGj86eFwpczq9uQwbnym7B tlwoeiOloH/l1qKRZSO7NAxxIlppXfOX8TLSoqzczEFsdlPIv/80zunZzHEz3kVsTv0j cDwS+IOmEsgXMZK2OQWDG+NTb5gTSbHpOB8GsQH7A674kIHGS7CuOcBT9ipWTugh5IRF mgsHnq89ttgvyOj5ITlY5Xk6dNWcY0oMcUguEYZZhqHEVy88+aFAfgS5S+mfSpaGHw7X iYj/tEP8F2uQh0S64848YMCsh0vKayEZ79FA1BFlpfDinLq1BIW2bB8wiOemQd+ygusM IlgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si9894092edq.326.2020.04.19.21.04.39; Sun, 19 Apr 2020 21:05:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725896AbgDTECp (ORCPT + 99 others); Mon, 20 Apr 2020 00:02:45 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2411 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725681AbgDTECp (ORCPT ); Mon, 20 Apr 2020 00:02:45 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AAF9E83FB686C24A5816; Mon, 20 Apr 2020 12:02:42 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 20 Apr 2020 12:02:36 +0800 From: Jason Yan To: , , , , CC: Jason Yan Subject: [PATCH] ext4: remove unnecessary comparisons to bool Date: Mon, 20 Apr 2020 12:29:18 +0800 Message-ID: <20200420042918.19459-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Fix the following coccicheck warning: fs/ext4/extents_status.c:1057:5-28: WARNING: Comparison to bool fs/ext4/inode.c:2314:18-24: WARNING: Comparison to bool Signed-off-by: Jason Yan --- fs/ext4/extents_status.c | 2 +- fs/ext4/inode.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c index d996b44d2265..e75171535375 100644 --- a/fs/ext4/extents_status.c +++ b/fs/ext4/extents_status.c @@ -1054,7 +1054,7 @@ static void count_rsvd(struct inode *inode, ext4_lblk_t lblk, long len, end = (end > ext4_es_end(es)) ? ext4_es_end(es) : end; /* record the first block of the first delonly extent seen */ - if (rc->first_do_lblk_found == false) { + if (!rc->first_do_lblk_found) { rc->first_do_lblk = i; rc->first_do_lblk_found = true; } diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 2a4aae6acdcb..acb8fedcba76 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2311,7 +2311,7 @@ static int mpage_map_and_submit_buffers(struct mpage_da_data *mpd) * mapping, or maybe the page was submitted for IO. * So we return to call further extent mapping. */ - if (err < 0 || map_bh == true) + if (err < 0 || map_bh) goto out; /* Page fully mapped - let IO run! */ err = mpage_submit_page(mpd, page); -- 2.21.1