Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3515357ybz; Mon, 20 Apr 2020 04:26:18 -0700 (PDT) X-Google-Smtp-Source: APiQypJQoOKazlhdv5cjC89UtHqMpOpGYYAZVxvSZX/19x+0PnISlTY29l7x2o5oepdn+79z3/Op X-Received: by 2002:a50:d7d3:: with SMTP id m19mr13971452edj.285.1587381977859; Mon, 20 Apr 2020 04:26:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587381977; cv=none; d=google.com; s=arc-20160816; b=lh9svxg2BkJdTCsMmCzTlmaPtAj6YCbcofor3VGAigCXQk/iTnl6N/+oZANxlbbJgN 4TUVSMlS2wsUayDsHHc4eBZMdlorVEqLjOoOAnwqu4AfBnZ0CwnE/TyfJazd4a1gFkvr YOz2XybWz1V06Abgk0dg3Lem9AonAQ3psDLO8TPQHVHStK9nyqEVRMrol16ZnBt9Vl/V xIVNZVKl9v1WQskHzwU0yg8gK1rcgdmPpFXO7IzU+5rF6SNYFRXLYnsBQlFKAaXeAr61 HMrIZpZWl4Ii9f4D/kdj59eh3uoq+glb0NAzC9qFgVJlblvzcvje2gfxKf++7GHPTN9N hLsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to:date :references:subject:cc:to:from; bh=7+pS/bZNQ0tdqrmNAAszDJoKcur/YyYe3bAkB2eUKUc=; b=TWThrYI3ltCRkrycFHYPGdGhtb4ttRyN/4Ix7EChNzPGvHUc2rEw4u7bDtegTvmILQ yUONFVwQzzBpDsfJonNjCB+K7cMF98Y7WLiaAoLl/EZhqWUvFiOFvgJKuyqS495TEFAS W9lrbJZbmXqs3dwRkU2ffH82zi5g18faxnke2D186MQKl36+AYosGmXoL6gIAYu7P5XD ufAxlS38kkymiaGuZgpOIc4gTB+XFmTVYnGEtYuHMvIevYslUKbj3orwZRl4FrRkkLMM fF58hKviGt4c6asSqa0RgY83YMbirxLTzPyUxUz3EIpBB8vGTh4uPHPKATRfDXQtHjqE wrQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si363571edb.221.2020.04.20.04.25.52; Mon, 20 Apr 2020 04:26:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726079AbgDTLX7 (ORCPT + 99 others); Mon, 20 Apr 2020 07:23:59 -0400 Received: from albireo.enyo.de ([37.24.231.21]:39026 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgDTLX6 (ORCPT ); Mon, 20 Apr 2020 07:23:58 -0400 Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jQUWn-00057d-MO; Mon, 20 Apr 2020 11:23:53 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1jQUWn-0002tR-Jr; Mon, 20 Apr 2020 13:23:53 +0200 From: Florian Weimer To: Peter Maydell Cc: Linus Walleij , "Theodore Ts'o" , Andreas Dilger , Ext4 Developers List , linux-fsdevel , Linux API , QEMU Developers , Andy Lutomirski Subject: Re: [PATCH] fcntl: Add 32bit filesystem mode References: <20200331133536.3328-1-linus.walleij@linaro.org> Date: Mon, 20 Apr 2020 13:23:53 +0200 In-Reply-To: (Peter Maydell's message of "Mon, 20 Apr 2020 12:19:17 +0100") Message-ID: <87v9luwgc6.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org * Peter Maydell: > We open fd 3 to read '.'; we issue the new fcntl, which > succeeds. Then there's some unrelated stuff operating on > stdout. Then we do a getdents64(), but the d_off values > we get back are still 64 bits. The guest binary doesn't > like those, so it fails. My expectation was that we would > get back d_off values here that were in the 32 bit range. What's your file system? I think not all of them have 32-bit hashes (some of them probably can't, particularly in the network-based file system case).