Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp313861ybz; Tue, 21 Apr 2020 09:30:25 -0700 (PDT) X-Google-Smtp-Source: APiQypJ8lAL4VOLEgE8IH30M0nL0Rra9a6zENqAmS8NF7No5iJzBfj3Tmyvg4KHTcj1OjI0Ke7Nq X-Received: by 2002:a05:6402:1d02:: with SMTP id dg2mr13907211edb.5.1587486624792; Tue, 21 Apr 2020 09:30:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587486624; cv=none; d=google.com; s=arc-20160816; b=NTnBcgmEjj6838QxGuwEn0HiFHwaKPzbtyQqToPum5wFvDvezB2ksmTZqmfHJKeKou Tf626oTZtL0Z2gFdPALMRmk6WpAau1mjKqGcuDJCXD2sPdFs09bqKZNChFW7u4rIcw7J SGq0GBV+VlfRMWAnCb5vPdDgt3ffd16pWfa2KgQ6FByTsye3VKBWIpOKUlTBOddlVIvR Yg4cxeLmnB7ugmOZ0lOb1dl8GpBU0mc/j1GTlyo427GcMgGVzelR+Hjx6qHFKoUgU+4S TVm/OA94O/ujMGPO/QErNTF+1veMOlMyb2Kddgi0N5gYRGTojVk69NttQ1gZecdVBkNB HW+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:auto-submitted :content-transfer-encoding:references:in-reply-to:message-id:date :subject:to:from; bh=cALM1qIcOsg0FuqmH+FY4hBc4gmrZWWe0/pMUuNbg9E=; b=s0iQrC+uRDdB3YRHRXRU1yO0zkNHyphh5d1qj4gnicYseGBLCRjBuAIzOEr4rur3Bb FpcQBSw1QVSvEFcZDftLB+5y8Iej69xtAx9tg4VcGhdPllJalh72I2iNKiwbHTTsrGCX 41qxVEyHR2Haw0ExuwZh8nOEGs3KYeQVpWiw5TxjgUHhD+A3ToeRflLfcr1cVvXeIqUn nrL54ndOPprdt2MbyuwSTzFijqKQA+ZCHlQQ5TuW2ULOsLyhPxZzP4dGcxepSnnbIi+M 7n8NdxMof897cepYuh5Q3Lnrrf0Fe8Bu9GgqL7L9Kqg/HCxqohmBg8dnDEfZfm5f1hxT Zgeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rs10si1702407ejb.288.2020.04.21.09.29.55; Tue, 21 Apr 2020 09:30:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728305AbgDUQ3P convert rfc822-to-8bit (ORCPT + 99 others); Tue, 21 Apr 2020 12:29:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:48718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgDUQ3P (ORCPT ); Tue, 21 Apr 2020 12:29:15 -0400 From: bugzilla-daemon@bugzilla.kernel.org Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: linux-ext4@vger.kernel.org Subject: [Bug 207367] Accraid / aptec / Microsemi / ext4 / larger then 16TB Date: Tue, 21 Apr 2020 16:29:14 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Product: File System X-Bugzilla-Component: ext4 X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jack@suse.cz X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=207367 --- Comment #10 from Jan Kara (jack@suse.cz) --- On Tue 21-04-20 01:04:05, Christoph Hellwig wrote: > On Tue, Apr 21, 2020 at 03:08:50PM +1000, Dave Chinner wrote: > > > 4. fs/jbd2/journal.c > > > > Broken on filesystems where the journal file might be placed beyond > > a 32 bit block number, iomap_bmap() just makes that obvious. Needs > > fixing. > > I think this wants to use iomap, as that would solve all the problems. Well, there are two problems with this - firstly, ocfs2 is also using jbd2 and it knows nothing about iomap. So that would have to be implemented. Secondly, you have to somehow pass iomap ops to jbd2 so it all boils down to passing some callback to jbd2 during journal init to map blocks anyway as Dave said. And then it is upto filesystem to do the mapping - usually directly using its internal block mapping function - so no need for iomap AFAICT. Honza -- You are receiving this mail because: You are watching the assignee of the bug.