Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp439131ybz; Fri, 24 Apr 2020 03:08:04 -0700 (PDT) X-Google-Smtp-Source: APiQypILptTysLmOle92UNp8mq3KnSXyQM0YRQHYEIoSCloHvU7IP2K5I2VmJ3fmtyR5pRo6sBVX X-Received: by 2002:a17:906:3d69:: with SMTP id r9mr6538161ejf.20.1587722883870; Fri, 24 Apr 2020 03:08:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587722883; cv=none; d=google.com; s=arc-20160816; b=FSXB0PicsM1+d3webSYRJEKBV1IcTcd6t2ImABAEob/VagUWY2cXCv6zwXJalxG0WK Rlaeu6+CKF45SWbNKbiGR6uW2tQbYBWyJJCdsgtTR97YtZMn6WIfYpcLpILV4rj+yfLY 6f8/lRXCbeyuLUo5Mg27rhEHVVAGipoW8UdIW8kjFxuzfsGD2uTMg4iJJYD4wfeIphvp EcC2C8G1vT7GbEQEv5IZC4YLmABH6OKsz6PlcowfYn4wMmY1ow5vnHS4cuLLwkEtInbN wC/GVACPnGjuNRORHeqcUf+KdmNK/GDjITk+jmo2o/ZTOU2BgTVJcBj6M5bXN/fYlT9t goyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Tp5Mwh7r6IJcLAecCyqpJ/TIyjlhLNkCAk6T+XXKm0U=; b=XcSaxXPEINeIDjmvFJt1G08s/K1IpLinOpgnuU+993C4vQ7uEou4UYKJI3hORW4zQW KUy+M59XMTSxafvZ0bbfXx3xFis9HDpKOr1+i3dWqN9OFvK8haI0253VaMY/ojnsvntI GksaqG3mo4I5Yt+PuszSLfdRROR3pRpX38Un4gsqke0Tx3gvnYAmKludMzoC7M67qTJ3 VToejxGMh9sV6qGVelrDZZGlOHY8QFWZl/cD/dWnsZpoKIAN72c6kindGNp/wRlcTjnx wyKf/LX6+6+EaHtuYek71tMQZrRCWyiAlIs72fkeUVTcI+i3CFz8TokiULSiskomXjev Mj6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eAhRMSwi; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nh5si2816942ejb.352.2020.04.24.03.07.38; Fri, 24 Apr 2020 03:08:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eAhRMSwi; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726770AbgDXKHU (ORCPT + 99 others); Fri, 24 Apr 2020 06:07:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726289AbgDXKHU (ORCPT ); Fri, 24 Apr 2020 06:07:20 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72F1DC09B045; Fri, 24 Apr 2020 03:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Tp5Mwh7r6IJcLAecCyqpJ/TIyjlhLNkCAk6T+XXKm0U=; b=eAhRMSwilNFW7B7zKTBZ5alNKJ fPFREmSw0xGNKNBzK63sZg1a8xpj8CJScj/VFUbRZx1x1NAI5Fm7fHAmBMl5pyeTQfDWTF7DQOL7F 9HwgWkueNAYejVuEyAhJAeIYAjIkCNLaHnVj1NgOOu4ypyjJO7Ljcwh01WYh1enEfR8BfimD5u5jt 1E8TEyq8yUJRI5PdA8rSafyMhUwNbcAMeuv6b31PjFl3sqakCabOOS7qd85J6tc0bBViPQ4z8lZ5U V4f1BYJ7HhnPZ6KQbVS5s8mc6eH1hUx4pjz0aVVffEu/E6MEjZhZNjVyidcCw7fHc8PGB3Xy3LI9X bIz6dzRw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRvEt-0000Ni-Cx; Fri, 24 Apr 2020 10:07:19 +0000 Date: Fri, 24 Apr 2020 03:07:19 -0700 From: Christoph Hellwig To: Ritesh Harjani Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Alexander Viro , "Darrick J . Wong" , Christoph Hellwig , Jan Kara , tytso@mit.edu, "Aneesh Kumar K . V" , linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/2] fibmap: Warn and return an error in case of block > INT_MAX Message-ID: <20200424100719.GA456@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Apr 24, 2020 at 12:52:17PM +0530, Ritesh Harjani wrote: > We better warn the fibmap user and not return a truncated and therefore > an incorrect block map address if the bmap() returned block address > is greater than INT_MAX (since user supplied integer pointer). > > It's better to WARN all user of ioctl_fibmap() and return a proper error > code rather than silently letting a FS corruption happen if the user tries > to fiddle around with the returned block map address. > > We fix this by returning an error code of -ERANGE and returning 0 as the > block mapping address in case if it is > INT_MAX. > > Signed-off-by: Ritesh Harjani Looks good, Reviewed-by: Christoph Hellwig