Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp559498ybz; Fri, 24 Apr 2020 05:26:07 -0700 (PDT) X-Google-Smtp-Source: APiQypKbhO6zx3WgRhhL7YFjL0tJx9Pl40FgSo6fhizolCv6pSR0saNGiPskMlLGBuAGCj5dNRxP X-Received: by 2002:a50:fc0d:: with SMTP id i13mr6455951edr.280.1587731167675; Fri, 24 Apr 2020 05:26:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587731167; cv=none; d=google.com; s=arc-20160816; b=kdHmPIog5atmMWcuNRnnqunmRNl+y624P5AwbS7EBDxu4J0Y/5b8iT/5/t7AP4Mkhj a1vs36U0fT3PFRq51LdHq14UCOGvNScEH0uFab4XhP0UjCaCsn8EAUDoNd5b0QEu5G5u KWxlfo1eQ4RuE69SXkzQAFV6LrjvZA2TCagoAH6pgVDWN0s8OMrXuaeHUHMNQkJNCfMX opyeUhVnXgLM0OP8mi6Ea2j4pN+c0siTNSBsHnNcTjWa3/zwm67h9KOy1v8ceYe8Xi/g IcyJIcN0s2T2csjSRPB5RiKlaiF8tayN9vtAnooeAV8yK9kQzTCTFLOOcdt2nkG7Z4Y/ pTzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vVjgr3Ynl8ogBLEPHXyIQysCD6TZ2GKWlmvlZFHl0ug=; b=utnf31UToLvhI7uTIhiltviM06fJNPCjfZPDZmrVUzFrUcL4PvuHuHuv7Ut161K4Aw 3DDdSbR8GRWxMv543dJ8ri+u7FYe61gIh0azJk/XonZID3GqGKhc0OAWv+XeSGDZyJA2 SMQ1FOK6AnpSPg3NBElycLq03FkWFx/23HuMqsm+ayWcR3Gkc5UyDEvqy47q0x281EGm 0qketSZJOQpBLW1/qhdEuw/zyEBX9E6t2g3cgES6G+LI5rr5XWT2I0BSJYr4eEQZw00P QVjKSfeg4nUDLMeppuxj+ApsMt1WE5JkOfbO0tjDoeiFdnYQl2PADCJbXnZ7EvnTjYuY kRIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gJTUAoRl; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lw9si2878849ejb.175.2020.04.24.05.25.42; Fri, 24 Apr 2020 05:26:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gJTUAoRl; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728326AbgDXMYP (ORCPT + 99 others); Fri, 24 Apr 2020 08:24:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:54714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbgDXMYO (ORCPT ); Fri, 24 Apr 2020 08:24:14 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78E2B2166E; Fri, 24 Apr 2020 12:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731054; bh=lvMF2Kf965DlYlL/TYNqQSc35y6WcqH57P/K98qb/3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gJTUAoRlGVs9so0pNiERJOPXYy2xslEfaD2zMjYSmKp2ekkb0vd6Fv9S5wGAiLWzZ 6afgNWTVWDL3n5hjURh5srpbXA8js60v119GKrnXcraCUaa//7YzeD4n3FG5yxTkbm KqWkVqNbOnD6FPXntAFOdGZzRHzqbvxjq7KmEJZ0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: yangerkun , Theodore Ts'o , Ritesh Harjani , Jan Kara , Sasha Levin , linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 15/18] ext4: use matching invalidatepage in ext4_writepage Date: Fri, 24 Apr 2020 08:23:52 -0400 Message-Id: <20200424122355.10453-15-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200424122355.10453-1-sashal@kernel.org> References: <20200424122355.10453-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: yangerkun [ Upstream commit c2a559bc0e7ed5a715ad6b947025b33cb7c05ea7 ] Run generic/388 with journal data mode sometimes may trigger the warning in ext4_invalidatepage. Actually, we should use the matching invalidatepage in ext4_writepage. Signed-off-by: yangerkun Signed-off-by: Theodore Ts'o Reviewed-by: Ritesh Harjani Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20200226041002.13914-1-yangerkun@huawei.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 000fa0e392787..3b1a7597af15e 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2128,7 +2128,7 @@ static int ext4_writepage(struct page *page, bool keep_towrite = false; if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) { - ext4_invalidatepage(page, 0, PAGE_SIZE); + inode->i_mapping->a_ops->invalidatepage(page, 0, PAGE_SIZE); unlock_page(page); return -EIO; } -- 2.20.1