Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2579541ybz; Sun, 26 Apr 2020 23:43:53 -0700 (PDT) X-Google-Smtp-Source: APiQypKIJrtx2hXFtJDUQJpeCvPFv5vfyGM/W2fhXTHsIdpHM1Z6mtcPOI5+I9lVkf5NeE/pgFXT X-Received: by 2002:a50:ec0c:: with SMTP id g12mr18088148edr.140.1587969833073; Sun, 26 Apr 2020 23:43:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587969833; cv=none; d=google.com; s=arc-20160816; b=Or3ZgeDEAEgJ0ylGACbEKyzXF5WpOprkQzSM5DLIwSlrB12+6vEm93OgNrFm++o0J3 lYS5uE3ilOyUek+vAg0VqEKafgHHzVgqV+o4HXPPW/saG3CD4aHIxPWsG9ArS+ne2fGL AaFa6p8aAWHdvwHAhhDX6YsfBTQDMWbvbJ7aWa/llrPHSWe9kJCD41JQsZL7z1tFyayv ZgbredgT6XdNbBb3wONJ76uAmz0zd+/VkgARdEeXoc9VGDJJYoD1EqfUCvZQ7EGRAwIP YiIENUgQoXwy74fdi0QPz2PpedxpGTLnS7bby2+4yP7LNLIi+zE5GnssKJRTMMWuhx6Y PgIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8XXy6DGHElkvvG3uRrBPJZZu9JuV2U/fqGOHJLpjlME=; b=rxmnq6JRhaAC89+MkbFs88uYSWwgbcEnHReKJ2UL+8/RLuRIo05YEwBAhecPRLuQ4N Vc+VDmKPe8PBa/gdvNN0iCQIY4r89Ph9Cpar464XJ8f+SJVZOriYXsVq/NSKts7a2kqM e/zQO2H7ZYLHLOsfx20h+l9HxO+RWeP4B/VuDQiB1DpOmDhBXG6Q232VP8r5rjm2mQot KCATF44+XsYjfki5JviDF8hiqyx86qL6a236YAejHr9Yth9cSgKpRHGQHzReDgT8dqcO H6Rb2YuPWMoYB7vamSWmcxeLB19td2T+jaef9IdJhqf/E+P4IcCQLA8vQq/ulciOlNml V+iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=fxJqCL+r; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nh7si7881188ejb.182.2020.04.26.23.43.25; Sun, 26 Apr 2020 23:43:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=fxJqCL+r; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbgD0Gmd (ORCPT + 99 others); Mon, 27 Apr 2020 02:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbgD0Gmd (ORCPT ); Mon, 27 Apr 2020 02:42:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C78BC061A0F; Sun, 26 Apr 2020 23:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=8XXy6DGHElkvvG3uRrBPJZZu9JuV2U/fqGOHJLpjlME=; b=fxJqCL+rgYyFO2hMnH5w4KcO0W e4oSzIclMzPkRxjG8/QAk9z3YkuxqXT3VfOkdyr2OoV65OLqQa0wQ7NipthQ2FBb+KQ8sQ239GF6N +6KGZZOeEoPV73F63KUN2awAD4XDdASc8P9N0euTkSQzyUyiIkgTRlXVrWzGEQeQ0Lu/x+WXRkovb iuRQUCrZIaRl7oUXgSoGwWZe7KtAE8FwlCVgZV/Bo+v0Cophs30Zbl/Hd4+QwCoESGMtoPry0vO9G Zf0EN+r2ZMMKpjq+GJJkJCNfypeh8QEFjUqp06l+YA4GCk9MgYqje4jhKhX3+DNd11kDajyDlKmet zNBqMpjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSxTL-0005WD-SY; Mon, 27 Apr 2020 06:42:31 +0000 Date: Sun, 26 Apr 2020 23:42:31 -0700 From: Christoph Hellwig To: Andreas Dilger Cc: Christoph Hellwig , Amir Goldstein , Ritesh Harjani , Ext4 , Jan Kara , Theodore Tso , "Darrick J. Wong" , Alexander Viro , Dan Carpenter , "Aneesh Kumar K . V" , Murphy Zhou , Miklos Szeredi , linux-fsdevel , overlayfs Subject: Re: [PATCH 0/5] ext4/overlayfs: fiemap related fixes Message-ID: <20200427064231.GA19581@infradead.org> References: <20200425094350.GA11881@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Apr 25, 2020 at 10:32:44AM -0700, Andreas Dilger wrote: > On Apr 25, 2020, at 02:43, Christoph Hellwig wrote: > > > > On Sat, Apr 25, 2020 at 12:11:59PM +0300, Amir Goldstein wrote: > >> FWIW, I agree with you. > >> And seems like Jan does as well, since he ACKed all your patches. > >> Current patches would be easier to backport to stable kernels. > > > > Honestly, the proper fix is pretty much trivial. I wrote it up this > > morning over coffee: > > > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/fiemap-fix > > > > Still needs more testing, though. > > The "maxbytes" value should be passed in from the caller, since this > may be different per inode (for ext4 at least). We should handle it, but not burden everyone else who has saner limits.