Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2704689ybz; Mon, 27 Apr 2020 03:00:00 -0700 (PDT) X-Google-Smtp-Source: APiQypJlvTGR3dsfnAEHW7ZAfhf5yhfr9ixJ7MZnGcUPOT/XNjwxX7UvG3KQgAocciZxkqUo7y/7 X-Received: by 2002:aa7:d653:: with SMTP id v19mr17406607edr.383.1587981599973; Mon, 27 Apr 2020 02:59:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587981599; cv=none; d=google.com; s=arc-20160816; b=jK+O8nkHj6Swdz/jxfUDbLVvNEiB77SsoB9tEkjaNoSAYoPLSHB8edpXvVUlXhPutM gDzwRFtzR7YOTjHUDB8n1OcFYCj6WrxvWyyfAfACYzjYr/pPY4WMMZOk5CCJXPjwkuH2 MN8MOK6cLbfzkAxZz8r4LT09vh7dXqiJh8bTSi53O6BvTXjArNuzjYcmxOpjLR1w1PzT gjDq6JG3MZaDVwoe29Wee2Gz0V47U18bGblvXM1nkrrlkJ7K2556sAnI1FrWiYzQsuUB VCki3S847/e+5ZTUivtoc9TV5BgZ4W5+dLjmEeRh8CHCvHTL9EG3NixPu+kLsxWG3m11 k6gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gZhdoYkjuvbpOueM83yzKSJUBUXDbflvgTLRFJS+QTc=; b=HoOHHaz5ujCYesoH+76iW5DsM93zBbmCX95FQQsemiEzgPpCuDiEfuqr7sFGoBCyx7 0kjTrTzvIpMtcM80vStL24OEFdukJReCOeOkfNVvvc4pa4+hCoMA7D09kL0amPMaavQo QiPpTvXYFHwcU0h/P662GRfouiXNc0h8njdJ8wYEo4CQk4yqFOud8E9nfyOK70SnYp85 DPV8ZS3wkH0Sl99MEn8OcXihY37n9WKBWOahLWCPEWPjWN3Z+BNUBIw9KTWTfrU4/1F4 rN2/T8UGkqG4YXmKmLuHhcZFqZqwhk6fTVbKhTANi4OJKbKjOz0LQdjSkwX2/Kk8VwrB Sqgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=egc5kG+G; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v3si8109624ede.381.2020.04.27.02.59.36; Mon, 27 Apr 2020 02:59:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=egc5kG+G; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbgD0J7O (ORCPT + 99 others); Mon, 27 Apr 2020 05:59:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726434AbgD0J7L (ORCPT ); Mon, 27 Apr 2020 05:59:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C9C6C0610D5; Mon, 27 Apr 2020 02:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=gZhdoYkjuvbpOueM83yzKSJUBUXDbflvgTLRFJS+QTc=; b=egc5kG+GVTRAk4M2K5JwCl+YSH c4IgpR1u4TjSs0pHrVDim1P8p7O9HbCLPYfHbXOuSfDd7PMgmoFLXh4qX2ZyFdArTfnXwelDJyIDQ wPI98m3X70sk5s+FQ9IwIrHVzYJqU3D+wjp4DoGd7Dg86ev1ll6Nqvb4xHfnGakmAELeeCP6gVxAL 4yeJT8yNq/pJ/48X/ZpZjyCeveAOhgRxwT8gSt/8Wnwx79X6P07c55x7jbGE02fxxHHyGjz2H648x 0G3ON9SsYPWoILEhSaI19VPcCSq4WVU3NYzWKNB2V1SKLKVHXAK/u/sG1EPKvAzdTgiBjytU+G+Ds YYi8NDhg==; Received: from [2001:4bb8:193:f203:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT0Xe-0003go-HB; Mon, 27 Apr 2020 09:59:10 +0000 From: Christoph Hellwig To: linux-ext4@vger.kernel.org, viro@zeniv.linux.org.uk Cc: jack@suse.cz, tytso@mit.edu, adilger@dilger.ca, riteshh@linux.ibm.com, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: [PATCH 4/8] ext4: remove the call to fiemap_check_flags in ext4_fiemap Date: Mon, 27 Apr 2020 11:58:54 +0200 Message-Id: <20200427095858.1440608-5-hch@lst.de> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427095858.1440608-1-hch@lst.de> References: <20200427095858.1440608-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org iomap_fiemap already calls fiemap_check_flags first thing, so this additional check is redundant. Signed-off-by: Christoph Hellwig --- fs/ext4/extents.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index d2a2a3ba5c44a..a41ae7c510170 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -4866,9 +4866,6 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, fieinfo->fi_flags &= ~FIEMAP_FLAG_CACHE; } - if (fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC | FIEMAP_FLAG_XATTR)) - return -EBADR; - /* * For bitmap files the maximum size limit could be smaller than * s_maxbytes, so check len here manually instead of just relying on the -- 2.26.1