Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2746155ybz; Mon, 27 Apr 2020 03:51:02 -0700 (PDT) X-Google-Smtp-Source: APiQypIuNg4LQGS/Tf1uNsvr7RboAElSwJjxRKoHSeH/rSTLCGk1mmw1TPkTG0idrQsXorL09fBh X-Received: by 2002:a17:906:8611:: with SMTP id o17mr18832689ejx.221.1587984662658; Mon, 27 Apr 2020 03:51:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587984662; cv=none; d=google.com; s=arc-20160816; b=cpwaLYX3rlBQ9FJJyXbXwmpx4GwH+uHgL/e9e9gj4ioExXcg9rErdp5dDiySRjdFEM P5+QaMCG2aT5infWCflDqbUVetyLnW0aMrTSGxtgOcI+OGOpvSrFrWrkcRzdwDhag67v AKfnZX21idOgq0VXHNLkvasiAgcP/3VL/mJngzc+LCHdIQfwk/z6M25NYNAqsBMpDibc 1Y5wRF9BRPxcLjmCqvq/IICXSKYa7slCsfus5ZZT3JcICpquj6jNSCvZWTMCuJHq3PeT bIZFZtFPyimGMZjkDo++fG1ZvEgGef3HAehsEczhfbCnZy9IKK7nSXd9qX57X2B3SX/t ZswQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=2A7Xi7s3sF49bid21RFRAulD6avmRUux+NN9IZM8s8o=; b=MYeUbCdNK4UYVJ32TtoUBE9F69HvHk2CsQXo26QII6YBGmSLKivc+NoAv1RmaOGhb/ 7RbGQW6RxOL1asp3X9MffWbL5OP+2HGmvZTuN22N4C0PV4w/cbRgcIer/qZ9qeH2/grq OJnG6xGj/TFZqdyYi5NxR+1ko6qGKwpvqK02Hg1g1A1JbRIktcAq6BxV0LYH9cqiBnqQ VVfNH+B15yhXUNyVmLEwvVTMcGFJExeyaa7+RVE17TDhn9/B/45BrU4wac/13nNb0mEW eDXCPa0IcrfqD8aFKHhVFM/KGm4yoabGA1lxYybQ4jA2EZkl3BQ3XXhxBpuguKTNjP2i iBUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mp3bYclP; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si7701710edv.512.2020.04.27.03.50.34; Mon, 27 Apr 2020 03:51:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mp3bYclP; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbgD0Kud (ORCPT + 99 others); Mon, 27 Apr 2020 06:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726507AbgD0Kuc (ORCPT ); Mon, 27 Apr 2020 06:50:32 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7A60C0610D5 for ; Mon, 27 Apr 2020 03:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=2A7Xi7s3sF49bid21RFRAulD6avmRUux+NN9IZM8s8o=; b=mp3bYclPYPQsNnVmcBBpLd7OgR ghbNurvREXauzMWP2vtt88yflnCL5LCNDFPWpN5CgKp/utQ2DARuxaiCQhu4F6IVewQKIAUFtMp1p H+rTqlrO3C2L/gmYlKy2omlt2396StNnOYov7LW6Qt1z3DizwFEAwBbJNffoirpSLtS0nRBiOk+AW nHYrTJeKL63wg+9aUoRdF+je/CDBwlt2jV8dgCPjG7h1YDdKDVQha9S3lb5afVFhEr/cK+lv4sxjk 2kr43KFgnC8XphLqj6roHojXhuwwrkdLW3kovQeb2OealhpmEgh1m1yaJxUDVdNmHNdE1NQ0oQoNZ mTz7zClA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT1LM-0001f9-Mp; Mon, 27 Apr 2020 10:50:32 +0000 Date: Mon, 27 Apr 2020 03:50:32 -0700 From: Christoph Hellwig To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org Subject: ext4 fiemap and the inode lock Message-ID: <20200427105032.GA27494@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi Ritesh, before you converted ext4 to use iomap for fiemap, the indirect block case used generic_block_fiemap and thus took i_rwsem around the actual fiemap operation. Do you remember if you did an audit if it was ok to drop it, or did that just slip in?