Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3177652ybz; Mon, 27 Apr 2020 11:20:51 -0700 (PDT) X-Google-Smtp-Source: APiQypIjMYaQkskXlez1b/i9e1Kbc8CFvs9DBM2uRgCnhk7C+4YsrOQ64auh3KBHPl4Cs0ba7AsI X-Received: by 2002:a17:907:214d:: with SMTP id rk13mr21465899ejb.220.1588011651211; Mon, 27 Apr 2020 11:20:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588011651; cv=none; d=google.com; s=arc-20160816; b=dA8jU9EPDMPlh1Wn8PAyggwczS7gP7ho/osYpM1d6gIfA84pAjZuAmQU+gt3MwyzwR l6QzknhaWrLbM62XpQYbd3Sn1Me7DMWIC/4pbENX5h/Lnpu+Dp4Iqz+n8AKtZN09VHy9 CXv2tCk9YP5Eda48vJeUwIfN7qowv+XW1RxrH3wGTHb0zpY1juvyx8hzbjs5Flb4/0s5 +aVoR4QghM7yHhKFwvbECyM9EeojNzgncMYjXdqjmysL2Xx1u/1J9XcmCU+YoaFZAkE6 tI5pP1pXAIDwJlWDMYGX2YyvKM9F1Jd+54RO/q1ZJkMHu4FzgnurWVhZEXld1WurIXt3 nRNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gZhdoYkjuvbpOueM83yzKSJUBUXDbflvgTLRFJS+QTc=; b=mrUXhHXCakASXaMaF0sax1c5+EHErxud8vtC7O+3fXHwj10gL2LrtyBcwev5CUQa9u Em7o1pjhEgGqGOlmmKOxVGITWsh81atP3iBv0UruU3oz0xsGv/QjYIJ3fpzHfG4zxjBH EfP/wZ/Ntegn698LNwA3n6ft8Q2GazNKbZzqRRQRPvozrLo9bpjHM4cbLPWGeeiroV0S 9+BRQ/hDST6CiqnDJ31s8A6gGEsKUcBc5+SyPoHcOPsckJlTcgRB5JDonxby5d4ouJmH U/apCtjIUs6gpXVVun8vsMKU8bTZS/A1wkY9DxoBJs0omD+pRAl+BHxd5rsLXt0hViGc roow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=izdrZisi; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si216138edi.597.2020.04.27.11.20.27; Mon, 27 Apr 2020 11:20:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=izdrZisi; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbgD0SUM (ORCPT + 99 others); Mon, 27 Apr 2020 14:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726223AbgD0SUJ (ORCPT ); Mon, 27 Apr 2020 14:20:09 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D16C03C1A7; Mon, 27 Apr 2020 11:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=gZhdoYkjuvbpOueM83yzKSJUBUXDbflvgTLRFJS+QTc=; b=izdrZisi9bf+E3dITzFP6ng0yD oTEhCwg2AgiJWFUqFz7mtC+8gkjdPLvcaIOvBpU01Kcv/BGroCLWlHpsdFjOnlyERY95KqbR9Lqtk jmcV1t4iieQ/r7aaQ/nuu5r85oH4vqfmkxup6QAqyYJ3UkovexfWoRLk4bekP8aZc8X1/gIzFkWwV xCzV3I17qvzjyHdUljyraiC+JLjGlGSIIloivnX1do6McV12eLQCbdJU9D9HlffDODWk5qZ09sEt9 kK6E0EkRO5f8D+567YBtQUcsn2f6BHbsTM2BGtKoFl7BH3t7mczz7hhB0ryobtFTZN0tGU8UBInPg OSg8QbQQ==; Received: from [2001:4bb8:193:f203:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT8MS-0003Jp-RT; Mon, 27 Apr 2020 18:20:09 +0000 From: Christoph Hellwig To: linux-ext4@vger.kernel.org, viro@zeniv.linux.org.uk Cc: jack@suse.cz, tytso@mit.edu, adilger@dilger.ca, riteshh@linux.ibm.com, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: [PATCH 04/11] ext4: remove the call to fiemap_check_flags in ext4_fiemap Date: Mon, 27 Apr 2020 20:19:50 +0200 Message-Id: <20200427181957.1606257-5-hch@lst.de> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200427181957.1606257-1-hch@lst.de> References: <20200427181957.1606257-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org iomap_fiemap already calls fiemap_check_flags first thing, so this additional check is redundant. Signed-off-by: Christoph Hellwig --- fs/ext4/extents.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index d2a2a3ba5c44a..a41ae7c510170 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -4866,9 +4866,6 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, fieinfo->fi_flags &= ~FIEMAP_FLAG_CACHE; } - if (fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC | FIEMAP_FLAG_XATTR)) - return -EBADR; - /* * For bitmap files the maximum size limit could be smaller than * s_maxbytes, so check len here manually instead of just relying on the -- 2.26.1