Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200427181957.1606257-1-hch@lst.de> <20200427181957.1606257-9-hch@lst.de>
In-Reply-To: <20200427181957.1606257-9-hch@lst.de>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Tue, 28 Apr 2020 05:35:10 +0300
Message-ID: <CAOQ4uxhY28otTkkkN7=2QQaONu6GwLcePE=q6J+po9Fv=HXFSw@mail.gmail.com>
Subject: Re: [PATCH 08/11] fs: move fiemap range validation into the file
 systems instances
To:     Christoph Hellwig <hch@lst.de>
Cc:     Ext4 <linux-ext4@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
        Theodore Tso <tytso@mit.edu>,
        Andreas Dilger <adilger@dilger.ca>,
        Ritesh Harjani <riteshh@linux.ibm.com>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        overlayfs <linux-unionfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 27, 2020 at 9:20 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Replace fiemap_check_flags with a fiemap_validate helpers that also takes

Leftover fiemap_validate

> the inode and mapped range, and performs the sanity check and truncation
> previously done in fiemap_check_range.  This way the validation is inside
> the file system itself and thus properly works for the stacked overlayfs
> case as well.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>


Reviewed-by: Amir Goldstein <amir73il@gmail.com>

Thanks for fixing this,
Amir.