Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4350491ybz; Tue, 28 Apr 2020 09:48:35 -0700 (PDT) X-Google-Smtp-Source: APiQypLSW/gDnRkUmujqVl0lrTKxZCZakK/JcLdJ4gr3bDA+YHc6VE7oovUEBIIvDvGWjEkIzFfA X-Received: by 2002:a05:6402:4ce:: with SMTP id n14mr25094004edw.32.1588092515772; Tue, 28 Apr 2020 09:48:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588092515; cv=none; d=google.com; s=arc-20160816; b=lCy/HSs/lIqpz0lLomoNXMgctcJRmSgOgMcXEj0Moinv4tq9Rf/BxscMFJmg23eKhg yIBFNg4hQLeUqveWHboEtZ6iFPIZPVW0z2SGPAJ4q4GQs0p3hQHTZ8beavsz9l4XPYJO axEHWVQ6xDu5eAFAuXHSHaVeSPsZMC6E7n0UgknMJIORHEcgbgFTsCM5gNyj2/QG8xxM xinWa64+kq/6K4SrDa+1Clbtv8FEsz4/iFKKpCQ4nJpxNg09uBhbV1BUla9ByvqGlIMY JjWELEoJ+v0edp6Nj6wXrSAnnlrXhw2umjjkSHuOVauqES+VO9hXJiKz5ms744I8/mKA QvmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mOc/rqjmnYu1udu600jsrqq/4WNi8OKKxTrPBFh4Sts=; b=i5pPEex7mfKHQy7Vnwmrn2iGFfJHgtTSakc7p16+w0QDoVHtutrjl/EMFx5xlLklff VcRJg6DApmH0wJyw844Px342mHum36xNDZMUKWl2vY5GDsUmHEAAD/uHPdx2xdZYKM4R /0yoT7Dgn1535Rmfc2gpvS3TvnLi9fcKjrqTv1HNdwUCx0qz5PTCLn+Of9D0MiaNl9yV Su4yeVmn0IXnE60HQ4B0n5x3Kpi0J1lDoqxY2W0ctCEJRudFb2YtGPBuF9f0EOXI4pu+ fQuwH3KaD1I2wL8Gr75D9xQRFgnWCiYkw1SLWTadFqSWh3QRWZEx/sPi9TavqRnShLJR q0mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=J2AljRHl; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g12si2323725ejw.314.2020.04.28.09.48.11; Tue, 28 Apr 2020 09:48:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=J2AljRHl; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728022AbgD1QsJ (ORCPT + 99 others); Tue, 28 Apr 2020 12:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727957AbgD1QsI (ORCPT ); Tue, 28 Apr 2020 12:48:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C433BC03C1AB for ; Tue, 28 Apr 2020 09:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mOc/rqjmnYu1udu600jsrqq/4WNi8OKKxTrPBFh4Sts=; b=J2AljRHlOc9nekrumLtoEqNil+ HRAfNuHC8RAArdvdGtAWPCwxv0dHfWvFq15y4vn+dg2r17Gb6z69aQGtitNTm8seyCfj3f2eaghi0 sLIISEg+ChQNpwx2M7NonqeMCx6EMSDg3eVp+Jh7MiWtiNp9pJc2F6N8/+KbFpPqKzXA/ys2aE182 csNxncniTTFJToKtxiZHRhX+iTgt6u0VaV6xnMpmft/i647+pIYZVm6Jdml5Rg76aGcHluv3mrucE pz/evlF9FE2v9EEMJcWT+kCXmTpcEky8WAmlv2cCTFJDx8ENQe63neWWv1JTbcWIgK1BePk27jRKH Z3oGlkeg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTTOy-0003T8-LO; Tue, 28 Apr 2020 16:48:08 +0000 Date: Tue, 28 Apr 2020 09:48:08 -0700 From: Christoph Hellwig To: Lukas Czerner Cc: linux-ext4@vger.kernel.org, dhowells@redhat.com, viro@zeniv.linux.org.uk Subject: Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4_msg() Message-ID: <20200428164808.GA3632@infradead.org> References: <20200428164536.462-1-lczerner@redhat.com> <20200428164536.462-6-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428164536.462-6-lczerner@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 28, 2020 at 06:45:24PM +0200, Lukas Czerner wrote: > At the parsing phase of mount in the new mount api sb will not be > available so allow sb to be NULL in ext4_msg and use that in > handle_mount_opt(). > > Also change return value to appropriate -EINVAL where needed. Shouldn't mount-time messages be reported using the logfc and family helpers from include/linux/fs_context.h? (which btw, have really horrible over-generic names).