Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Apr 2020 04:09:47 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Ian Kent <raven@themaw.net>
Cc:     Lukas Czerner <lczerner@redhat.com>,
        Christoph Hellwig <hch@infradead.org>,
        linux-ext4@vger.kernel.org, dhowells@redhat.com,
        viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4_msg()
Message-ID: <20200429110947.GA6290@infradead.org>
References: <20200428164536.462-1-lczerner@redhat.com>
 <20200428164536.462-6-lczerner@redhat.com>
 <20200428164808.GA3632@infradead.org>
 <20200428165747.ondq7nbn4ol3j3lu@work>
 <4f6598e12127cc6e80af7dde5149220d92b07b11.camel@themaw.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4f6598e12127cc6e80af7dde5149220d92b07b11.camel@themaw.net>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 29, 2020 at 10:53:00AM +0800, Ian Kent wrote:
> The mount-API log macros tend to cause user confusion because they
> often lead to unexpected log messages.
> 
> We're seeing that now with bugs logged due to unexpected messages
> resulting from the NFS mount-API conversion.
> 
> I'd recommend mostly avoiding using the macros until there's been
> time to reconsider how they should work, after all fsopen() and
> friends will still get errno errors just not the passed string
> description.

And when is that time going to be?  Should we convert existing users
back and remove that functionality if it doesn't work properly?