Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1752469ybz; Thu, 30 Apr 2020 05:01:52 -0700 (PDT) X-Google-Smtp-Source: APiQypKgN6CMialpizx4yDei1f08k86sLkkaUN952Zgw/XndIKsxd52444A+v5JU7ec52R5j1R+P X-Received: by 2002:a17:906:37d0:: with SMTP id o16mr2217453ejc.368.1588248112304; Thu, 30 Apr 2020 05:01:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588248112; cv=none; d=google.com; s=arc-20160816; b=n9JOhXdhtoKOsf2wnwhZJzPPmftEH4G0IGZ49ogcHCjLUHvD2tqwDZbHoGilWpRUnt 6vYuEi6DCYBndQd3WQcv5hgYPXBJMvvWdsNv1dN+B16Zw+lOC09sGq60r+8WdiAoIxCe 7+yE+WNk5dmpTSAcXbEI42d7K3MLdXxMnPnfCQQu4AqjPKYXpJoFiPX2wCp9u1CF880G oFxl4F0h8b7d6ZSqIMA2JvOw0LggNCNiE6RR5RIre875btD2/xUWn5C6tggjiaMPKcGJ HjGwFNNOuPBADThXpgHL7sWBTrUE2ctzTXACqZTXh32b7ch1mxtG9mGMWY0l8aHNLHJt PYmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:dkim-signature; bh=6QyXfeGvk0WJl1C/wpxTI5v1ePziEcWn5TI+lV37Q2o=; b=U/9r47IPlb7+xIVN6WGj5VGGGBKm5xruHHNVvrBq12UfXOfOK+quJi+QsJH0DsaDJM oSNkmTNMp2Mi1oH4dHxi7y9rxII4EGicw1GIrc8gFXJGmUaebEBX+Ya6Nk/dk8LIscYT iSVhHRe2hg0YEOZsrSsuYKcqE4+Ep18jN02GLqv8bK4jjuyIDlu0oUCQ1eYPaaaAADPM 8BWtdNv/BAjL20f9b3FJP2/GQ6MOQJiV2qf8IZRwUcZ6LPZAcB3ZOQRDyZWFPmyMckgj gHTWA/PWhOVAe746E7DF8PIx9VcNRHhUsvQrOmA9H9IBlQgPrehSt2GwVe72aIm6lNn8 juXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lHUzr6c6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e15si5834001ejq.285.2020.04.30.05.01.27; Thu, 30 Apr 2020 05:01:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lHUzr6c6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbgD3MAl (ORCPT + 99 others); Thu, 30 Apr 2020 08:00:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727071AbgD3MAM (ORCPT ); Thu, 30 Apr 2020 08:00:12 -0400 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D7E1C09B042 for ; Thu, 30 Apr 2020 05:00:12 -0700 (PDT) Received: by mail-qv1-xf49.google.com with SMTP id m20so6145466qvy.13 for ; Thu, 30 Apr 2020 05:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=6QyXfeGvk0WJl1C/wpxTI5v1ePziEcWn5TI+lV37Q2o=; b=lHUzr6c6MetvkriJhe93sddCtRY+ZweoxlpD0BwPFJmdTfXeYzzmA0Gu6yNBk+pP7/ UH3cuhC+GVG6blJxjxnaR14HtfobUHdOEuWUBCG9E4APIacaE87QXzbYvQ6Rw0FgVixT Lrv3AjdK2vLcyJY5/nQjDZadmjZ5GS1BIwHMA1iUvaEhMYcoNSZ2nkWtHLPEAAz6sLPJ K9wZ0HuxMknqy+Zm4SNjyA0FVkgVj3KAtW6afgV1oOwAJO0H160AKm6PQhRWmvgESXEo I5A+pDK5p7T6fE/S+NgWww/J/0MTwLXj3aut4jaBorKo5yWxAViQloDNDeQrCDWEjwKM lErQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=6QyXfeGvk0WJl1C/wpxTI5v1ePziEcWn5TI+lV37Q2o=; b=U5ygZEylqhpMC/DorLC0Ks7ooc4noxBimPq45K1KctAOWLOxAPsysZARwuiWBLXqSN lYfeQ7Ekqqn3HLbTGPx2PN+B2dC7bY2d3Zw0JGIc6zOv5VXru7IwZ5gbGstFAD17w7Mc I5BzbyAOQTaWXbveU/d0s0NQGK+c0wJ5CUq/1nqAVrl0nfB+PtnOIuEULLGuRBXG6Ttp 27x0Va5PF9EQyq2LEaPyy2HeQUCk6PEyE6d2LVluodfb3I9ACZNQSHJBhQ09SWnKt0ZT 3AMe4rcPdVkMkje2a6RSuS6lEOpl/wU7drr8Qr2EaEwPEESDSC91cI6jJ/4n2vVsaGcb sybA== X-Gm-Message-State: AGi0PuaLxe8EKuP9jAgbhvtRtQrky73zAueszBEfB2CxsO+dTOdXUPVA oqucNjR5g62MkYWkkyBUoh6ARqJNyMY= X-Received: by 2002:a0c:b31b:: with SMTP id s27mr2671309qve.158.1588248011455; Thu, 30 Apr 2020 05:00:11 -0700 (PDT) Date: Thu, 30 Apr 2020 11:59:53 +0000 In-Reply-To: <20200430115959.238073-1-satyat@google.com> Message-Id: <20200430115959.238073-7-satyat@google.com> Mime-Version: 1.0 References: <20200430115959.238073-1-satyat@google.com> X-Mailer: git-send-email 2.26.2.303.gf8c07b1a785-goog Subject: [PATCH v12 06/12] scsi: ufs: UFS driver v2.1 spec crypto additions From: Satya Tangirala To: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org Cc: Barani Muthukumaran , Kuohong Wang , Kim Boojin , Satya Tangirala Content-Type: text/plain; charset="UTF-8" Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Add the crypto registers and structs defined in v2.1 of the JEDEC UFSHCI specification in preparation to add support for inline encryption to UFS. Signed-off-by: Satya Tangirala --- drivers/scsi/ufs/ufshcd.c | 2 ++ drivers/scsi/ufs/ufshcd.h | 6 ++++ drivers/scsi/ufs/ufshci.h | 67 +++++++++++++++++++++++++++++++++++++-- 3 files changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 698e8d20b4bac..2435c600cb2d9 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4767,6 +4767,8 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) case OCS_MISMATCH_RESP_UPIU_SIZE: case OCS_PEER_COMM_FAILURE: case OCS_FATAL_ERROR: + case OCS_INVALID_CRYPTO_CONFIG: + case OCS_GENERAL_CRYPTO_ERROR: default: result |= DID_ERROR << 16; dev_err(hba->dev, diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index 6ffc08ad85f63..1eebb589159d6 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -555,6 +555,12 @@ enum ufshcd_caps { * for userspace to control the power management. */ UFSHCD_CAP_RPM_AUTOSUSPEND = 1 << 6, + + /* + * This capability allows the host controller driver to use the + * inline crypto engine, if it is present + */ + UFSHCD_CAP_CRYPTO = (1 << 7), }; /** diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h index c2961d37cc1cf..c0651fe6dbbc6 100644 --- a/drivers/scsi/ufs/ufshci.h +++ b/drivers/scsi/ufs/ufshci.h @@ -90,6 +90,7 @@ enum { MASK_64_ADDRESSING_SUPPORT = 0x01000000, MASK_OUT_OF_ORDER_DATA_DELIVERY_SUPPORT = 0x02000000, MASK_UIC_DME_TEST_MODE_SUPPORT = 0x04000000, + MASK_CRYPTO_SUPPORT = 0x10000000, }; #define UFS_MASK(mask, offset) ((mask) << (offset)) @@ -143,6 +144,7 @@ enum { #define DEVICE_FATAL_ERROR 0x800 #define CONTROLLER_FATAL_ERROR 0x10000 #define SYSTEM_BUS_FATAL_ERROR 0x20000 +#define CRYPTO_ENGINE_FATAL_ERROR 0x40000 #define UFSHCD_UIC_HIBERN8_MASK (UIC_HIBERNATE_ENTER |\ UIC_HIBERNATE_EXIT) @@ -155,11 +157,13 @@ enum { #define UFSHCD_ERROR_MASK (UIC_ERROR |\ DEVICE_FATAL_ERROR |\ CONTROLLER_FATAL_ERROR |\ - SYSTEM_BUS_FATAL_ERROR) + SYSTEM_BUS_FATAL_ERROR |\ + CRYPTO_ENGINE_FATAL_ERROR) #define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\ CONTROLLER_FATAL_ERROR |\ - SYSTEM_BUS_FATAL_ERROR) + SYSTEM_BUS_FATAL_ERROR |\ + CRYPTO_ENGINE_FATAL_ERROR) /* HCS - Host Controller Status 30h */ #define DEVICE_PRESENT 0x1 @@ -318,6 +322,61 @@ enum { INTERRUPT_MASK_ALL_VER_21 = 0x71FFF, }; +/* CCAP - Crypto Capability 100h */ +union ufs_crypto_capabilities { + __le32 reg_val; + struct { + u8 num_crypto_cap; + u8 config_count; + u8 reserved; + u8 config_array_ptr; + }; +}; + +enum ufs_crypto_key_size { + UFS_CRYPTO_KEY_SIZE_INVALID = 0x0, + UFS_CRYPTO_KEY_SIZE_128 = 0x1, + UFS_CRYPTO_KEY_SIZE_192 = 0x2, + UFS_CRYPTO_KEY_SIZE_256 = 0x3, + UFS_CRYPTO_KEY_SIZE_512 = 0x4, +}; + +enum ufs_crypto_alg { + UFS_CRYPTO_ALG_AES_XTS = 0x0, + UFS_CRYPTO_ALG_BITLOCKER_AES_CBC = 0x1, + UFS_CRYPTO_ALG_AES_ECB = 0x2, + UFS_CRYPTO_ALG_ESSIV_AES_CBC = 0x3, +}; + +/* x-CRYPTOCAP - Crypto Capability X */ +union ufs_crypto_cap_entry { + __le32 reg_val; + struct { + u8 algorithm_id; + u8 sdus_mask; /* Supported data unit size mask */ + u8 key_size; + u8 reserved; + }; +}; + +#define UFS_CRYPTO_CONFIGURATION_ENABLE (1 << 7) +#define UFS_CRYPTO_KEY_MAX_SIZE 64 +/* x-CRYPTOCFG - Crypto Configuration X */ +union ufs_crypto_cfg_entry { + __le32 reg_val[32]; + struct { + u8 crypto_key[UFS_CRYPTO_KEY_MAX_SIZE]; + u8 data_unit_size; + u8 crypto_cap_idx; + u8 reserved_1; + u8 config_enable; + u8 reserved_multi_host; + u8 reserved_2; + u8 vsb[2]; + u8 reserved_3[56]; + }; +}; + /* * Request Descriptor Definitions */ @@ -339,6 +398,7 @@ enum { UTP_NATIVE_UFS_COMMAND = 0x10000000, UTP_DEVICE_MANAGEMENT_FUNCTION = 0x20000000, UTP_REQ_DESC_INT_CMD = 0x01000000, + UTP_REQ_DESC_CRYPTO_ENABLE_CMD = 0x00800000, }; /* UTP Transfer Request Data Direction (DD) */ @@ -358,6 +418,9 @@ enum { OCS_PEER_COMM_FAILURE = 0x5, OCS_ABORTED = 0x6, OCS_FATAL_ERROR = 0x7, + OCS_DEVICE_FATAL_ERROR = 0x8, + OCS_INVALID_CRYPTO_CONFIG = 0x9, + OCS_GENERAL_CRYPTO_ERROR = 0xA, OCS_INVALID_COMMAND_STATUS = 0x0F, MASK_OCS = 0x0F, }; -- 2.26.2.303.gf8c07b1a785-goog