Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp350193ybz; Thu, 30 Apr 2020 23:31:10 -0700 (PDT) X-Google-Smtp-Source: APiQypJ1Eb8zap20SE0C7B2NOWcGQre3pSva7Z/azHi1le7T02OHdBgynSpO4lcRCP65q0U3+BLx X-Received: by 2002:a05:6402:129a:: with SMTP id w26mr2204872edv.254.1588314670627; Thu, 30 Apr 2020 23:31:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588314670; cv=none; d=google.com; s=arc-20160816; b=R6xE9Pxw8pNc1yD3uq4lIf4Ez7PnIp/leCXLo0FX+Cr/rVuKLWzBdLu4iLOsRIIBCi 4N7GMizqhYbeYWpNQbLGNTz8nC5OCfmUaOCkSZqJ1KihUP6AhavBRZxTgFAFhtbEgP29 Ijz8Hg3X8k7nqWu8FFl/xHw5wXkrudwCPB6dUkxzFVkdhTnJflfTS76EYvvn1gHFnThj Ji0+m4bptlE61GwNYYKbbBJVNBFv7tv1YvyNEZ/CBoQfvO1bgtMJFGCp8ynEL6WPYuo0 2iERsSkdxoc/1i/3crqtw2vTLCdaD9NwAAjJ4hBB7CwT3nBdtiMTFnU4Jwa1jhuOLz3J SwAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=FX8Edaeum/WO1rSxjk7RQUBf5jSJgLJ5LApVdt7rBCg=; b=b25/UVd+2RhQlZShu29AhG5WbJCctrmJ4ukQ5Vhi37upWJcMjpNSJp3bQM6JPTxLsd 6NosHdrZLkN+2QxsYOe7s3tF88FLcwpd0InEyVRt0ObU+bPDieYkw0iOr5nGIAIAO+RD 6P2xZIfm9JNNzug8m4y3a/oFWxw2TG2jvl+fQOV958weh4R3LROaU4xr77JYRED4nqew 1s1/4nv8pGDfZbJAuVM2/FqwZ8HHFJQY5I/rVtJWLqmiTmwXTVNs61ZpNMu5WOirlc5C aJlbQfHRTD98rMle5av3/lHLpsc7d/pp5tetwpU57l3riKG20d53rbd2xk/Q7xr4Fgse LDZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm21si1147061edb.275.2020.04.30.23.30.34; Thu, 30 Apr 2020 23:31:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728242AbgEAGa0 (ORCPT + 99 others); Fri, 1 May 2020 02:30:26 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:6222 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728126AbgEAGaZ (ORCPT ); Fri, 1 May 2020 02:30:25 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04162mdu022249; Fri, 1 May 2020 02:30:20 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 30r7md9jsc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 May 2020 02:30:19 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 0416AvA1030095; Fri, 1 May 2020 06:30:17 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma03ams.nl.ibm.com with ESMTP id 30mcu5v4yy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 May 2020 06:30:17 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0416UFOP62062776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 May 2020 06:30:15 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DC8A8A405B; Fri, 1 May 2020 06:30:14 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4C510A405C; Fri, 1 May 2020 06:30:13 +0000 (GMT) Received: from localhost.localdomain.com (unknown [9.85.81.13]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 1 May 2020 06:30:12 +0000 (GMT) From: Ritesh Harjani To: linux-ext4@vger.kernel.org Cc: "Paul E . McKenney" , linux-fsdevel@vger.kernel.org, Jan Kara , tytso@mit.edu, "Aneesh Kumar K . V" , Ritesh Harjani Subject: [RFC 03/20] ext4: mballoc: Do print bb_free info even when it is 0 Date: Fri, 1 May 2020 11:59:45 +0530 Message-Id: X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-05-01_01:2020-04-30,2020-05-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=867 priorityscore=1501 suspectscore=3 clxscore=1015 phishscore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005010044 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Improve the debugging msg by also printing even if bb_free is 0. Signed-off-by: Ritesh Harjani --- fs/ext4/mballoc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 6bb08bb3c0ce..478b33fb1183 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -4202,8 +4202,6 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac) } ext4_unlock_group(sb, i); - if (grp->bb_free == 0) - continue; printk(KERN_ERR "%u: %d/%d \n", i, grp->bb_free, grp->bb_fragments); } -- 2.21.0