Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 05/11] fs: mark __generic_block_fiemap static
To:     Christoph Hellwig <hch@lst.de>, linux-ext4@vger.kernel.org,
        viro@zeniv.linux.org.uk
Cc:     jack@suse.cz, tytso@mit.edu, adilger@dilger.ca, amir73il@gmail.com,
        linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
References: <20200427181957.1606257-1-hch@lst.de>
 <20200427181957.1606257-6-hch@lst.de>
From:   Ritesh Harjani <riteshh@linux.ibm.com>
Date:   Sat, 2 May 2020 04:52:13 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20200427181957.1606257-6-hch@lst.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <20200501232214.D62C4AE053@d06av26.portsmouth.uk.ibm.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


On 4/27/20 11:49 PM, Christoph Hellwig wrote:
> There is no caller left outside of ioctl.c.


Looks fine. Feel free to add
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   fs/ioctl.c         | 4 +---
>   include/linux/fs.h | 4 ----
>   2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/fs/ioctl.c b/fs/ioctl.c
> index 282d45be6f453..f55f53c7824bb 100644
> --- a/fs/ioctl.c
> +++ b/fs/ioctl.c
> @@ -299,8 +299,7 @@ static inline loff_t blk_to_logical(struct inode *inode, sector_t blk)
>    * If you use this function directly, you need to do your own locking. Use
>    * generic_block_fiemap if you want the locking done for you.
>    */
> -
> -int __generic_block_fiemap(struct inode *inode,
> +static int __generic_block_fiemap(struct inode *inode,
>   			   struct fiemap_extent_info *fieinfo, loff_t start,
>   			   loff_t len, get_block_t *get_block)
>   {
> @@ -445,7 +444,6 @@ int __generic_block_fiemap(struct inode *inode,
>   
>   	return ret;
>   }
> -EXPORT_SYMBOL(__generic_block_fiemap);
>   
>   /**
>    * generic_block_fiemap - FIEMAP for block based inodes
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 4f6f59b4f22a8..3104c6f7527b5 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3299,10 +3299,6 @@ static inline int vfs_fstat(int fd, struct kstat *stat)
>   extern const char *vfs_get_link(struct dentry *, struct delayed_call *);
>   extern int vfs_readlink(struct dentry *, char __user *, int);
>   
> -extern int __generic_block_fiemap(struct inode *inode,
> -				  struct fiemap_extent_info *fieinfo,
> -				  loff_t start, loff_t len,
> -				  get_block_t *get_block);
>   extern int generic_block_fiemap(struct inode *inode,
>   				struct fiemap_extent_info *fieinfo, u64 start,
>   				u64 len, get_block_t *get_block);
>