Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <3DF89355-488D-47F5-857B-3B75D4E89AD3@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_E97399A6-AA4C-4985-B73D-29C7E126622B";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2
Date:   Mon, 11 May 2020 14:19:06 -0600
In-Reply-To: <5b9bc322-fe02-72cc-9aa7-a27b26894ce0@jguk.org>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     Jonny Grant <jg@jguk.org>
References: <5b9bc322-fe02-72cc-9aa7-a27b26894ce0@jguk.org>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_E97399A6-AA4C-4985-B73D-29C7E126622B
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On May 8, 2020, at 2:36 PM, Jonny Grant <jg@jguk.org> wrote:
> 
> Please find attached patch for review.
> 
> 2020-05-08  Jonny Grant  <jg@jguk.org>
> 
> 	tests: comment ext4_dir_entry_2 file_type member
> 
> Cheers, Jonny
> <ext4_ext4_dir_entry_2.patch>

Hi Jonny,
thanks for your patch.  The patch itself looks reasonable, but can
you please submit it as inline text next time.  To avoid issues with
whitespace formatting, you can use "git send-email" directly from
the command-line after making a commit with this change in it.

Also, the subject line of the patch should just have "ext4:" as the
subsystem, you don't need the whole pathname for the file, like:

    ext4: add comment for ext4_dir_entry_2 file_type member

Finally, you should add a line:

    Signed-off-by: Jonny Grant <jg@jguk.org>

to indicate that you wrote the patch and you are OK with others using it.

See Documentation/process/submitting-patches.rst for full details.

Cheers, Andreas


--Apple-Mail=_E97399A6-AA4C-4985-B73D-29C7E126622B
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl65szoACgkQcqXauRfM
H+D4xw/7BbSbyLelhVI//5yx9zK5xX5L/Tjj4ed/EwJRk32Pa8CmwUa3hASbMhRz
31a9pDGq2X1Cb5bgZbRjdjIhZYW8V6h4ukjmUssIj6QcjFo2PFUoJqJy3Qfxl8He
J4d++iHSTEQbs6EI4l9BmyHCowWjxJr7IrCnJ0JirzQRH83QoVE0+Rz4hKsh61/4
x5ihL76qdYgtJBXVF+020sbOZR6mPra6UNmq0zGSD0aX3srPplrzmgptc9Fc6Yvf
HdTyxMqViLqZcOUaeTgKWBS0YnjMYFHQmyA8KBnrahUZZaBm2erk9/Xf9aamrHHE
gAdyjZ5PhiMgq2dxPv5bRqISE3EU27VKPitCIuOeEfMtrLp4VOViEBCxAevPkwSx
UEDD10J5Kehc468MMYtuNE6JFHct8Iiy5pK5is9/l7VwTv0026gzdXx+wuQCbHzU
HQXlLP07cr+WGn6CBoXu751mGkgpeBPTFa0eSNsW3efLitGpkOaITDjJy6AMfEKC
q+KNaWSHv8+M6o3IesA5x3kCNNJDsM7uFBNJmXAwaSgG08jzq1ZjF1unyEBufs2O
uQd1VW2ZGolSMu6OxlCqwefUVdghwtfh741/v0vBDABathey18xLgxchrH6aQNa7
373MZgFG8qo1lu4Kv5qTB2kpsmzTC/Pe+jT18wmJXim970gViA0=
=AwS9
-----END PGP SIGNATURE-----

--Apple-Mail=_E97399A6-AA4C-4985-B73D-29C7E126622B--