Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1369411ybk; Thu, 14 May 2020 07:22:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkDHOjBVr1hlbHPG0sRa1qvv8a6M0jvKtHtI/2dAxkV8xA6lrQUJszevqZ7YjNPVx3u8XT X-Received: by 2002:a50:c3c2:: with SMTP id i2mr4353538edf.227.1589466122176; Thu, 14 May 2020 07:22:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589466122; cv=none; d=google.com; s=arc-20160816; b=CKQtrGs+SGXOFasLusB8zNw88PIK7YdzoLaYrHjLYdk7AO+3AePrMb0fva6Nfq6Pg8 R1bkxYZWGqCUBm2uZURe1yjrE7DOXrVsOdxsVyCOjTkDiKiz2PcFIsQeQl4MQmsrYHN0 yAh/4vmu2yg3aU8MVCKlARYjRRRlLpQj4YmGCDNnwq9tlHEWTbMNxFKB67D9+67DGEan 7Ft3Qhn/p15uVRr2guGusNQ2l6ASgaChcMKZH+v/l6yp+FI7+SVQURw6OgTNe7PqICF3 KuMSFMJWxxlN6LGzrdS3PLCfk0dEM3IG736fL2VFOm5T4licvpw0EvGlarna2F2WPZ+X TXFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6jMc52ji3C1b6+OY5TXsXXf1v+qvf42DN0EL2A0egWc=; b=Ghkcd9AvnXcmpEr63+kKAksleYnOhnI4FbGkCSUBMPTFY7EpHb5RCacxlQnHU9tsmE 3KUCePN2K6Wywd+PTjRhC6X/b+MR4VG+4Qx30bjY3yExys+tKimE+26NTCSXyg//mCMs hMJ3KKSKzmpQpxSRNIfwrDRhNTsg6A6sYPHukiIEScc8iqn7LRiD6R1bvK9X7u7pIG3N ChSYsJaaec+LJWCSg3SplSL4vbaN9p8o5wrryb1IsRJapAsIBlBTK8tZyvFAdWbJo2sk X0ZlfHyNeee7eeTi/ZTillelvB7WnBlBbuCd885ImnGfSLViPLl2SC6s595xQTS/Rdu/ 0Yrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j4si2046001ejn.341.2020.05.14.07.21.30; Thu, 14 May 2020 07:22:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbgENOV2 (ORCPT + 99 others); Thu, 14 May 2020 10:21:28 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:54135 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726051AbgENOV2 (ORCPT ); Thu, 14 May 2020 10:21:28 -0400 Received: from callcc.thunk.org (pool-100-0-195-244.bstnma.fios.verizon.net [100.0.195.244]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 04EEKGiG028521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 May 2020 10:20:16 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 05569420304; Thu, 14 May 2020 10:20:15 -0400 (EDT) Date: Thu, 14 May 2020 10:20:15 -0400 From: "Theodore Y. Ts'o" To: xiakaixu1987@gmail.com Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, Kaixu Xia Subject: Re: [PATCH] ext4: remove redundant variable has_bigalloc in ext4_fill_super Message-ID: <20200514142015.GA2060213@mit.edu> References: <1586935542-29588-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1586935542-29588-1-git-send-email-kaixuxia@tencent.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Apr 15, 2020 at 03:25:42PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > We can use the ext4_has_feature_bigalloc() function directly to check > bigalloc feature and the variable has_bigalloc is reduncant, so remove > it. > > Signed-off-by: Kaixu Xia > Reviewed-by: Andreas Dilger Applied, thanks. - Ted