Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1388849ybk; Thu, 14 May 2020 07:50:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOVVi8BzBrN47di7TqGsucdTNuW7FDkYia3/Cc5XO4I4wLwEdRMxE9Knchi4qTXEpnCSSa X-Received: by 2002:aa7:dd14:: with SMTP id i20mr4165137edv.225.1589467820672; Thu, 14 May 2020 07:50:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589467820; cv=none; d=google.com; s=arc-20160816; b=KTE6TLv8zzPVtgojodmAxQp+Mks79H+VJfMkqv14Kv/ERCpSKOFxGaAi0jznwUPtHk 3mPZss99OxAdV8kd9yTteNYO5je72GWytpGBy8ObTqI8mkCyuoOLpOSMEZWvLaacse/Q 4hALZTBpRB4JZjtxPHszlZI6apodBp/A/+iyN+Fxv0pfnRaE4hRL4NykXW0hvDt/5Xyv 2VGQEE3fdGq2alWNPK7y6/OTq+kX6qqBbEejr0iBrye7m8xrufOBt1VCNF9rQmxbRRnZ yv4O9TqaxP5PDfvZyfREs3FdSO6Fr2FpUzaE62HNdoYOQXSdVlirsQ6mHzzQEK1N5ZRs G6Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gzdZgNQCq7ZvxA4wh2dwJhDfZo+mLCOrhZcT4ekPvAs=; b=q+q9EnVn+Q2oBzVfnWZwLIJqC7fhGPbmwqCaycoJ02QLljf0XWGK4Pd0df9rB4RY+l MCTGETbwW8taHlUQzBuqn/3z+EdZrn3XTDwlMsEnKzs5a/5hhTbamTPD2TvoRu7dB1Np CSy+rnUZyRkQgYt3Gxrb2JdOApkSRYFwRZ4D/KR5VUc8S5eY7C/M9GKeGwo7rSH+PSS6 1bq1ZsxqjEdNNKp+Ojkbq8WBHRL26XCnWcFekUNwww7UJzk3ZCCxzG3ABX1dgRVtJuRy CaEkOLiC2cfdNsau1bnGGTPDlzcZC0S20Cw9+969iEdjX6oiW372p8Kd3mKzR+QvweWC 8BlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v26si2003684eje.322.2020.05.14.07.49.57; Thu, 14 May 2020 07:50:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbgENOtu (ORCPT + 99 others); Thu, 14 May 2020 10:49:50 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:58458 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726176AbgENOtt (ORCPT ); Thu, 14 May 2020 10:49:49 -0400 Received: from callcc.thunk.org (pool-100-0-195-244.bstnma.fios.verizon.net [100.0.195.244]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 04EEnf5I006413 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 May 2020 10:49:42 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id CB172420304; Thu, 14 May 2020 10:49:41 -0400 (EDT) Date: Thu, 14 May 2020 10:49:41 -0400 From: "Theodore Y. Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: fix EXT_MAX_EXTENT/INDEX to check for zeroed eh_max Message-ID: <20200514144941.GT1596452@mit.edu> References: <20200421023959.20879-1-harshadshirwadkar@gmail.com> <20200421023959.20879-2-harshadshirwadkar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421023959.20879-2-harshadshirwadkar@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Apr 20, 2020 at 07:39:59PM -0700, Harshad Shirwadkar wrote: > If eh->eh_max is 0, EXT_MAX_EXTENT/INDEX would evaluate to unsigned > (-1) resulting in illegal memory accesses. Although there is no > consistent repro, we see that generic/019 sometimes crashes because of > this bug. > > Ran gce-xfstests smoke and verified that there were no regressions. > > Signed-off-by: Harshad Shirwadkar Applied, thanks. - Ted