Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1485026ybk; Thu, 21 May 2020 08:00:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuZipIrZ5pu/Rex8BH4N8uZgwszyyWWAhEoE05vYjt5mztyeTG8GnvZKbyVn2RvsqbcvqT X-Received: by 2002:a17:906:dbef:: with SMTP id yd15mr3864356ejb.5.1590073247173; Thu, 21 May 2020 08:00:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590073247; cv=none; d=google.com; s=arc-20160816; b=Kb4baWRbUwidkUCLGGaprhqnB5srODdwkVMxMQfIK6Nk/kSWvR4AoCjAecBUo99MY/ fJL5+Vx5Bri0aqOBqog8oltD/rzPXg4/0Ect64zD29UKqWDvYdMzJpR2Yb9M7R2mLs6M cEnQmRZADQsvP1pgUtGj5H4k2LcRIOckkLR0E8V+5iCAEoJwXl1oHCBMpc4yxz6NsCfY pfwCNK2jz+XvtmodXVVRNni03g4muuhBfn2Nj0LLST3Od2SJchTLz4IA1aa9bB75sXbv raFP/XGm9LlombTMkV0D/3Ocz7z5jZceyAyWqipR2jyMohbZT+lWehUkxCo98iqYzmXZ INOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Jvp87DhoLaz5qTT4SN9dQKeun2yO8QPkf4gGhedpyik=; b=dWfcvAA+fqHKFyT54OwIJUJfAEDkGGr4cf3HYrMK5GV0PiUcRfGgVQENsF948uadg5 xBCn8ce6IEl1wBdMWooiABbMzHBCrAZdsK6jJIVbCXi6UER8/hkbpr/snl0ierpp9293 VBE8ZuJCHkZcnTu652F3Nhgo66BXwCh9WliX1IS23ajNBWU8XYkKF6OY1QeSnh+x5gKd 8kIfDGKlcBJYwRtJttVc2V2HtsGg8rgGV9LU7oLsxSpAtITEl2MiigJejTnuTPgzrbTk /xnzrvKN4DsEGbP32/X1PDhYljGx8S60IbLadAIF1pfcAkN6c4XL7PLxX1SEmua2x76P YP6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr9si3723187ejc.163.2020.05.21.08.00.10; Thu, 21 May 2020 08:00:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729731AbgEUO7x (ORCPT + 99 others); Thu, 21 May 2020 10:59:53 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56047 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728162AbgEUO7x (ORCPT ); Thu, 21 May 2020 10:59:53 -0400 Received: from callcc.thunk.org (pool-100-0-195-244.bstnma.fios.verizon.net [100.0.195.244]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 04LExmiI019032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2020 10:59:49 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id C299B420304; Thu, 21 May 2020 10:59:48 -0400 (EDT) Date: Thu, 21 May 2020 10:59:48 -0400 From: "Theodore Y. Ts'o" To: Eric Whitney Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 0/4] ext4: clean up ext4_ext_handle_unwritten_extents() Message-ID: <20200521145948.GD2939819@mit.edu> References: <20200430185320.23001-1-enwlinux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430185320.23001-1-enwlinux@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Apr 30, 2020 at 02:53:16PM -0400, Eric Whitney wrote: > Changes made to ext4 over time have resulted in some cruft accumulating > in ext4_ext_handle_unwritten_extents(). This patch series removes > some dead and some redundant code, simplifies and corrects some error > handling, and adds explicit error logging when an unexpected internal > error or file system corruption may have occurred. > > Eric Whitney (4): > ext4: remove dead GET_BLOCKS_ZERO code > ext4: remove redundant GET_BLOCKS_CONVERT code > ext4: clean up GET_BLOCKS_PRE_IO error handling > ext4: clean up ext4_ext_convert_to_initialized() error handling > > fs/ext4/extents.c | 81 ++++++++++++++++++++++++++--------------------- > 1 file changed, 45 insertions(+), 36 deletions(-) Thanks, I've applied this patch series. - Ted