Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH] ext2: drop cached block when detecting corruption
To:     jack@suse.com
Cc:     linux-ext4@vger.kernel.org
References: <20200603094417.6143-1-cgxu519@mykernel.net>
From:   cgxu <cgxu519@mykernel.net>
Message-ID: <398a6fd8-37ee-c323-b606-c8679067e540@mykernel.net>
Date:   Thu, 4 Jun 2020 14:26:49 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200603094417.6143-1-cgxu519@mykernel.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On 6/3/20 5:44 PM, Chengguang Xu wrote:
> Currently ext2 uses mdcache for deduplication of extended
> attribution blocks. However, there is lack of handling for
> corrupted blocks, so newly created EAs may still links to
> corrupted blocks. This patch tries to drop cached block
> when detecting corruption to mitigate the effect.

ext2_xattr_cmp() will carefully check every entry in the block,
so there is no chance to link to corrupted block, maybe we can
improve the speed of cache related operations by dropping
corrupted blocks.


Thanks,
cgxu