Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Jun 2020 01:03:14 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>,
        linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: i_version mntopt gets visible through /proc/mounts
Message-ID: <20200617080314.GA7147@infradead.org>
References: <20200616202123.12656-1-msys.mizuma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200616202123.12656-1-msys.mizuma@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 16, 2020 at 04:21:23PM -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> 
> /proc/mounts doesn't show 'i_version' even if iversion
> mount option is set to XFS.
> 
> iversion mount option is a VFS option, not ext4 specific option.
> Move the handler to show_sb_opts() so that /proc/mounts can show
> 'i_version' on not only ext4 but also the other filesystem.

SB_I_VERSION is a kernel internal flag.  XFS doesn't have an i_version
mount option.