Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1103877ybt; Thu, 18 Jun 2020 00:05:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysXBWQ7om0qSNiBGDRegCQ8lKg7FPH7IfOBgHnKLRuJeHlTd5CD2qQNMgsbs6mMQ/4ocPB X-Received: by 2002:aa7:c15a:: with SMTP id r26mr2626063edp.21.1592463919256; Thu, 18 Jun 2020 00:05:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592463919; cv=none; d=google.com; s=arc-20160816; b=V2JpNzGtz/GiP4jUfOJtXczd3xFeGSCCGJOArrkwn18JNxChVQk7Irx/rWEHFZrwCf RofujEXTzTzLSFVLLR0Alt9ypdYUFHvnhkSmoQ+tFPP6unpYq9alfS4cmnKZOJg+KA+R 2H4weRYs9pZRAYt0z5K6j51P6/Y+a4RIaVWzpmN2/du/VQZNEV0xDTPZYs3UNzuWpx0f Whey0YMvKF+NWV7fetrBEJDn0e3QcrlymZ+CSQKfEY1RU21SiDcKINRt8wKwPAiCexlx 9XQ6BFGb/4vJA8/SizW4eFR0cagoZepq8KPvrHr1j69geSjqRXsTOxqyMhTGKx4nWPPz IB+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QeWZYFyZPeVYUVgtMVuAQSchGJrX+PQLlP9RVpSQLEw=; b=bDPfuKxki14wZdZ5aj7jASQJjExKdXRa3521tZ3Sb6X6fYcDmZ2otgMFjLSYbySWv8 6JueL+Q6+TirCMF+GdOxpvX4gv9UgdLhTX58j3+LWLPYeE8corT7vzdmRjYXf03hswK0 1k+mEinp8J2bJjaaVumD1BmX7HDXBAPqhbajWyAPwXoEDJXcA2MkYA2TLmoVFtTePxBG vwsWYIMY4fnw+vxyJItfOf0uPCfqioQ/pb7JYanxlhKDchlqX2UB3aCzSLNd7tnW+z2C dhlMsdB2PW3dmNpSdTOdH+mTa5hgXiXseHJN9/zNg/6irtvBOru31GGNJ7eT77qgLwLz 92dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=DoRGetgf; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz23si1386061ejb.168.2020.06.18.00.04.50; Thu, 18 Jun 2020 00:05:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=DoRGetgf; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbgFRHCw (ORCPT + 99 others); Thu, 18 Jun 2020 03:02:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727109AbgFRHCv (ORCPT ); Thu, 18 Jun 2020 03:02:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0216C06174E; Thu, 18 Jun 2020 00:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QeWZYFyZPeVYUVgtMVuAQSchGJrX+PQLlP9RVpSQLEw=; b=DoRGetgf8ZarSqISlgBkVxVPmM +UXlVruWXwoQCs/muSfz3cAJeAjhoPmI24K2xNassrzlsX2y/PzxZyYrE009ao32j2jMfpGtBUwGO lgt4pX9uzkwf1XcNivEhmHmTo9nzSWv6F8xNMte4XQn9W+94mqM0z457MXiz0HecgWx/gj7P/U4ap VOdfiT4k3KTPFOzAYZ1MSxoAT4gv1UaJ3vDHcvlpAxIlSmbbJUh5pDrquAbzxAR6TJI917RqfZHM0 XOVw3Ziogo+Kq7dNU8vCpmBt7h8eUJD+YHhblBAI0yPQ0pGIj0BhnShMa++cKXPHsrtza6SXtFrsX 9ORZ+fgA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jloZX-0004Hh-8q; Thu, 18 Jun 2020 07:02:51 +0000 Date: Thu, 18 Jun 2020 00:02:51 -0700 From: Christoph Hellwig To: "zhangyi (F)" Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca, zhangxiaoxu5@huawei.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/5] fs: add bdev writepage hook to block device Message-ID: <20200618070251.GA16046@infradead.org> References: <20200617115947.836221-1-yi.zhang@huawei.com> <20200617115947.836221-2-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617115947.836221-2-yi.zhang@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 17, 2020 at 07:59:43PM +0800, zhangyi (F) wrote: > Add a new bdev_write_page hook into struct super_operations and called > by bdev_writepage(), which could be used by filesystem to propagate > private handlers. Sorry. but no. We've been trying to get the fs decoupled from the whole buffer_head crap for quite a while, and this just makes it much worse. Please don't add layering violations like this.