Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1429987ybt; Thu, 18 Jun 2020 08:29:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzt9do92TrZOZQc4mVOM8F8utYPhrXLCKrcQt6nB/xGIwnRvo8UfiqfdISdO9k6etgHCjoY X-Received: by 2002:a50:c44b:: with SMTP id w11mr4799014edf.317.1592494194661; Thu, 18 Jun 2020 08:29:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592494194; cv=none; d=google.com; s=arc-20160816; b=WUhNLdf8bDR1t8tHUjO6NCNeUCs8Mm1F43O21GzNqpX7SdqXxfD7ImltjWmcFZUiJz Trv+HRYxIFP7AJ9ppLY86Wmby517728Qb/b3eLKiH5xsOWjZl/fgAx80pY/VjLPaj8hV FFQr0ZsExAi3uojhpVh4Gw+zsOoMOt4i7Q8T5/8hjA1cQSfvje8VukEK5PlMVpDcmvyH w0YWMPYrlBLMol8ASeQ+aKs4oUQW/x0aIi0DJt+aZJSRuiOv4DoHdKdi/1cj/SCSYmu4 9p2aziX4XSwGpFbsJcXaaRtOJmd+Ppnnik7xxAYqK9aGcLS5jbvBEWl+yYCAFFXaOAu3 z1aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=Pj3QnV1F9sep4avLnVMWVNXOW1kFyUq+/zRTjNJYlyI=; b=q1epsCrUVUIsKC7Lx8o08y74YKxIHnsz4R0Y66YNiV2bXkj4Ky/KvhIj4Qs9A5DIEh IupufjPqTOmc3UehG0WPtZZB72Rl1nv0bgFiA8aAJlfdIKKyb6F5H1U0KRhnCH2cGdTd k2754eym1njfz/oSpAIQdwuKc9dN/EioiUF22W2Z290OKKiofCiirL7ZjmqWGT5MLIj7 In8o4MOmXHqHjTxiwT3IolA/rjJFlte+rjJFeaUN/uBCpfXcLS4joBq78la7VP3PBZFP rIPhSkTQokdETfqZ2m/4qzPTegvUkGx2G0G8S3D6anh67epECmkjsvNKvaLTyhy6DxOn 4R1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ng8suade; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch8si2206211ejb.345.2020.06.18.08.29.30; Thu, 18 Jun 2020 08:29:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ng8suade; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731522AbgFRP3H (ORCPT + 99 others); Thu, 18 Jun 2020 11:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731531AbgFRP3E (ORCPT ); Thu, 18 Jun 2020 11:29:04 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12331C0613ED for ; Thu, 18 Jun 2020 08:29:04 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id 64so2925285pfv.11 for ; Thu, 18 Jun 2020 08:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Pj3QnV1F9sep4avLnVMWVNXOW1kFyUq+/zRTjNJYlyI=; b=Ng8suadeZ0Uja+8pfDVundngIPULO/tnKSqI45SqAbX3BdJSREwHnH1VG30sqEaOWw 8FnXJruUMvTPlvE1F1gQt7xq36B+N7q9CT/qvyxRgc2V2oP2k+D6eMDNauImtNSDZKId IDyGZHLKiNuJIGkybrYHpzGh21WZXfLIc6g3Mw/jSZoe8nkFTT21jCHBzZyYjrvkpvZC UQmNOY+0L0CbrACxc3yQp5DpiAkKau09n3H5t1KqVnKUnc+7mabrE5QPgOPeJUldteg+ H6U9aCSrVf/ucGD+NqD/QQfHIwzNhqakr5/uDZDxFWFdEe/1qZyDXi9o/ks4P38xyLbQ E/2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Pj3QnV1F9sep4avLnVMWVNXOW1kFyUq+/zRTjNJYlyI=; b=LTx6OQQnrrxvb++u/HFuFlHtYMroWCnnLhKk6QEuyfyWCY6BS5SQN0e+R9eeouZqVx 9qeZrlKnS4RJ+33I17FpSizHI7X+t1eMRENh+uAF13TRgAScR7JVCO1GIbu5OBrNedFx ckljtY2fwsluK3XPOUCOzJ/A/MZn8QSmqdhUz3sa9CXSm2CPKvEZTd5F7xaRqy2yGVdq ubnVkyQ685lcRNAUJQRVrgsZfX3Oz1srecZ7pT4XK73nAesAanUb20be4BaEfZutfqw+ cDToA4lv15UXIC80ldDKChVO0ozl5k1uR5coAnf1HMwZuldejmnJikHt0J+WfmLSw07G ZvHQ== X-Gm-Message-State: AOAM532CjtB05zJQigLwlebrAzNPd/zhhR2fHF56S7LAwSNROdAZE6+0 BPn0pw6k/CIilLCEZRyHzvr8oJSdLn8= X-Received: by 2002:a63:f502:: with SMTP id w2mr3699768pgh.321.1592494143166; Thu, 18 Jun 2020 08:29:03 -0700 (PDT) Received: from localhost.localdomain (ftp.datadirectnet.jp. [182.171.80.51]) by smtp.gmail.com with ESMTPSA id y81sm3306650pfb.33.2020.06.18.08.29.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jun 2020 08:29:02 -0700 (PDT) From: Wang Shilong To: linux-ext4@vger.kernel.org Cc: lixi@ddn.com, adilger@dilger.ca, wangshilong1991@gmail.com, sihara@ddn.com, Wang Shilong Subject: [RFC PATCH v2 21/51] e2fsck: rbtree bitmap for dir Date: Fri, 19 Jun 2020 00:27:24 +0900 Message-Id: <1592494074-28991-22-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1592494074-28991-1-git-send-email-wangshilong1991@gmail.com> References: <1592494074-28991-1-git-send-email-wangshilong1991@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Li Xi Only rbtree supports merge, so use it for all bitmaps. Change-Id: I863687ce275f9c891cd2d18c115cb75c6e24f4e4 Signed-off-by: Li Xi Signed-off-by: Wang Shilong --- lib/ext2fs/gen_bitmap64.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/ext2fs/gen_bitmap64.c b/lib/ext2fs/gen_bitmap64.c index 2617ac22..7bae443f 100644 --- a/lib/ext2fs/gen_bitmap64.c +++ b/lib/ext2fs/gen_bitmap64.c @@ -86,7 +86,6 @@ static void warn_bitmap(ext2fs_generic_bitmap_64 bitmap, #define INC_STAT(map, name) ;; #endif - errcode_t ext2fs_alloc_generic_bmap(ext2_filsys fs, errcode_t magic, int type, __u64 start, __u64 end, __u64 real_end, @@ -109,11 +108,7 @@ errcode_t ext2fs_alloc_generic_bmap(ext2_filsys fs, errcode_t magic, ops = &ext2fs_blkmap64_rbtree; break; case EXT2FS_BMAP64_AUTODIR: - retval = ext2fs_get_num_dirs(fs, &num_dirs); - if (retval || num_dirs > (fs->super->s_inodes_count / 320)) - ops = &ext2fs_blkmap64_bitarray; - else - ops = &ext2fs_blkmap64_rbtree; + ops = &ext2fs_blkmap64_rbtree; break; default: return EINVAL; -- 2.25.4