Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1431808ybt; Thu, 18 Jun 2020 08:32:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDoaRe9uge8Q4fAAZw/qP8Mpn0fiBwWNpHNfK0AkR1+F7pfxLeSzuKWB5tzh3KuSSQVVkr X-Received: by 2002:a17:906:7d97:: with SMTP id v23mr4197240ejo.199.1592494325314; Thu, 18 Jun 2020 08:32:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592494325; cv=none; d=google.com; s=arc-20160816; b=l66VjO4f/KqpUEfAAotLxzr/S4egqi854zIU2qSFYIOCrumL0uiO5BD2YVwEi1iIXt 0WbRQRYIR9qye00n9OUqVDUR/lr/mRlRr6+vXIz6vik2PyG03oNdwssP6XOYu8EpACzX NdOdyBYdiwbKHTvCxHMYZDZKClek/+3x0lj2ML0JCAnlAyoH9V1XtXA4m+j0QzO5kE9K 3HYV65zlVcV2CJ/xsHCvy59fxQJ2up4KYqrCD+tT729czPWxoOq0PYlS1aEm5eFrYYCT hWYFV6s5yE6DXjzuPG6Nsor/1QEyEzvxMlgINnxErgOCkJ+97ABMBSp/T2eyC0tys/3s masA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=d2YnaOgtbX0ScW7yoDd5TcUP4cnYYDyfxeaqwQkvP1E=; b=B8xjUXyVZlt42UTi5G7bOiBMxehfQbXKjPZ/hV79nGUc0iToBkPQ0fEVBs0Vq2tBdg VWlIy84vGDyvWi8llKRRXRIqm0iLelEAewsft2eYHwGFUOPF+dj5pZZuDgs3Q4nwxE6U urzLlqkkKWp5+jPJ2XB32FTO2QKaCQnQAQfHoSDYcNqs8YcWIx/qJcD686fwbqnfNd6S kb3qDsGNSfoc/oOjL1FjNf8rl8GixO92BIp/Lbo/7oX23LFAvcs+miRx9L1k6tYj8GUP ShwiA5/gvOXdJWvwRobTid1GKY8NOJRoje3IFjQmILkhoJyb2pSPaV4TXozuRcdZrlEO CtAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=S6Kp2GRK; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e20si2022504ejx.262.2020.06.18.08.31.42; Thu, 18 Jun 2020 08:32:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=S6Kp2GRK; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731554AbgFRPaO (ORCPT + 99 others); Thu, 18 Jun 2020 11:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731622AbgFRPaI (ORCPT ); Thu, 18 Jun 2020 11:30:08 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1FA1C0613EF for ; Thu, 18 Jun 2020 08:30:06 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id b201so2962296pfb.0 for ; Thu, 18 Jun 2020 08:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=d2YnaOgtbX0ScW7yoDd5TcUP4cnYYDyfxeaqwQkvP1E=; b=S6Kp2GRKqoM+e/uMSSenPVLCy1hhVnQemTUCnF3jpxT+InNXyUpkpsImSsfd+J8cnX kX5Fdi8Cw98j8g2OOWPmuqrsR2HPdQcf0PBVXkynlP3LexPHhFkXd2TXECmTU3r5Rsc5 ngyscOe51bpYuxfnmUdbDZzTUw3RKnH43PxK7elPWhUyJ4hVIjbaEJ0JYQl0prNj0AGK fB11Ng6uWT6/vH0JoEPubDWaK2Y7GBTLxFtv7ZevDOxWJVA724Rwk1ncfjKD4M3ztszT tmEfgZ1kB/gze90maNB+JW1VVENy98xXsELW3188chZHpcAsKVRtfErKXIDFmctY9x3i yGRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=d2YnaOgtbX0ScW7yoDd5TcUP4cnYYDyfxeaqwQkvP1E=; b=XgyfnqMCXd3oJV/nT0XSQ1AIcgU5aYnhfwaega2iQPzsLOowg4bewgEIyKsk6R8lVV ER+kvcb21y8MAkCierC/fa+4khry4zxfXqthjZDIhE8lnAj5j0CUCPIBOyawkTjmjTQs qZcIdhwElIhYsk+E8el7B802Q+0U88RBF9w4qN2FeItKpCFiPY8+oW8wtjnTxxCV/vMl a/OLDAZmbGwz3Uovp8KhLqHL9q66s4xD1Lp5FZg6sJSdqYZc7DWU9huPceU0z9q61GOz 4Tgl3AaO1EIqg/8OOKq/77oAYJ1KBGhYzG9uz1m9HOPrkPUnTRMIEA0vLrt0Q/whJq+6 +gdg== X-Gm-Message-State: AOAM530JfP4lrWA+oh5R+WPuC91ht47XZ8OTqC8MKeZgNAjY9bJo65yH qA5GIjz/DzH3h3MJ/x7BPisEG6+2/Lg= X-Received: by 2002:a63:7a56:: with SMTP id j22mr3629848pgn.194.1592494205990; Thu, 18 Jun 2020 08:30:05 -0700 (PDT) Received: from localhost.localdomain (ftp.datadirectnet.jp. [182.171.80.51]) by smtp.gmail.com with ESMTPSA id y81sm3306650pfb.33.2020.06.18.08.30.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jun 2020 08:30:05 -0700 (PDT) From: Wang Shilong To: linux-ext4@vger.kernel.org Cc: lixi@ddn.com, adilger@dilger.ca, wangshilong1991@gmail.com, sihara@ddn.com, Wang Shilong Subject: [RFC PATCH v2 47/51] e2fsck: only set E2F_FLAG_ALLOC_OK if all threads succeed Date: Fri, 19 Jun 2020 00:27:50 +0900 Message-Id: <1592494074-28991-48-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1592494074-28991-1-git-send-email-wangshilong1991@gmail.com> References: <1592494074-28991-1-git-send-email-wangshilong1991@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Wang Shilong Signed-off-by: Wang Shilong --- e2fsck/pass1.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c index d56b7128..45e8090b 100644 --- a/e2fsck/pass1.c +++ b/e2fsck/pass1.c @@ -1375,9 +1375,12 @@ static void _e2fsck_pass1_post(e2fsck_t ctx) { struct problem_context pctx; ext2_filsys fs = ctx->fs; + char *block_buf; - char *block_buf = - (char *)e2fsck_allocate_memory(ctx, ctx->fs->blocksize * 3, + if (e2fsck_should_abort(ctx)) + return; + + block_buf = (char *)e2fsck_allocate_memory(ctx, ctx->fs->blocksize * 3, "block interate buffer"); reserve_block_for_root_repair(ctx); reserve_block_for_lnf_repair(ctx); @@ -1455,6 +1458,8 @@ static void _e2fsck_pass1_post(e2fsck_t ctx) ext2fs_free_mem(&block_buf); ctx->flags &= ~E2F_FLAG_DUP_BLOCK; } + + ctx->flags |= E2F_FLAG_ALLOC_OK; } @@ -2309,7 +2314,6 @@ void _e2fsck_pass1(e2fsck_t ctx) goto endit; } - ctx->flags |= E2F_FLAG_ALLOC_OK; endit: e2fsck_use_inode_shortcuts(ctx, 0); ext2fs_free_mem(&inodes_to_process); -- 2.25.4