Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1603078ybt; Thu, 18 Jun 2020 12:36:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz526tNIrq13e379nmnoE9l1VW1IfB03681U96enP93jDlswDETfxhdUz4rHl7i1kgSc210 X-Received: by 2002:a17:906:fc13:: with SMTP id ov19mr274510ejb.212.1592508965694; Thu, 18 Jun 2020 12:36:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592508965; cv=none; d=google.com; s=arc-20160816; b=Xt138ksBW7f2/0+/NU0l9LTFUrF7NqmDxt1oJG9aDt2aJ+V/At0bad6ScE94/fddFZ 41/6WhpT3jEkerGozuLGOtolUCdIhp/bzv7rVhRm9Rdlxx+S/4yhVE7kt/4qwUT09Apx +XqTjIep6DqQFvBerJdr1oeMqKYO/+b7pF+qo1HTJa+lP3d/ul6YHN1571o4TXbCbP3x 4sZFv5cSxWl790LE8AVIl9vZJl4G8uNzqFL4G9VE6JKpiT4lv/nqe2B/xc7LhsICKyLj DW+PDm/a1N7CdnDWoyeqffaqA8OMtDIKSrP38xd4ZHGbcX4Ql5gphtEkZ4CroPp/b0ep sFNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FMMELEeEhdTTI2E0mWMuOefpye/AeVO+VP027XMPH08=; b=hoOeYwFrMqduLXY0zMS8BnwaJ1CeBHdZHdewGNv6I8vK8aE3h8tz62nP/TXhALwNVX DFZpYtkiixpIn/r6ieIMUDqS162/KcMZp0XuPlpgsWejpW18yQfZfo4awgU5Yq9yW7q5 gTCrcltuzu9HyWmFgexdAE2ypXeATrzPIk+jfAHM7d6zaUMWfj04rTBOTi5G3BA6ER7m 2QTofzyo20fPIzkzfqW9sNidHuCnbG9LmtrG1YtDWgHJYODNsai51sknZTAs1oqUwxzE QJRPqDkI0+nT8+TdAT5G8PK964QsEnCex2jTobIjHZWKK5zluRNPM/xYV3P37192uAzn rp8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="0s/GzQDa"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p18si2356364edm.288.2020.06.18.12.35.41; Thu, 18 Jun 2020 12:36:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="0s/GzQDa"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727978AbgFRTfZ (ORCPT + 99 others); Thu, 18 Jun 2020 15:35:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:44254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726879AbgFRTfY (ORCPT ); Thu, 18 Jun 2020 15:35:24 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28B3D2070A; Thu, 18 Jun 2020 19:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592508924; bh=M6NwrIk8NEqDFtZ1LIjdjdGZVm45nmjh1JS/p9T1PV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0s/GzQDavX3Bi6wq70IJY7QVFsGQxpHsC7VUkp4Wov3iEMW2eBO/5ufyuBA9CWcZZ VmDjkfo9bWPEAzSAtHWLCHRv8Xq8RykzeAMnLnHKU8xAhOqdzC9pgUEI3g8QwibjVq dCB5TpvrgaFTipvY1DbgwEnKKvu6QpnQf6CeBHmo= Date: Thu, 18 Jun 2020 12:35:22 -0700 From: Eric Biggers To: Jaegeuk Kim Cc: Chao Yu , Satya Tangirala , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org Subject: Re: [PATCH 3/4] f2fs: add inline encryption support Message-ID: <20200618193522.GD2957@sol.localdomain> References: <20200617075732.213198-1-satyat@google.com> <20200617075732.213198-4-satyat@google.com> <5e78e1be-f948-d54c-d28e-50f1f0a92ab3@huawei.com> <20200618181357.GC2957@sol.localdomain> <20200618192804.GA139436@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618192804.GA139436@google.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 18, 2020 at 12:28:04PM -0700, Jaegeuk Kim wrote: > > > > It would be helpful if there was an f2fs mount option to auto-enable compression > > on all files (similar to how test_dummy_encryption auto-enables encryption on > > all files) so that it could be tested more easily. > > Eric, you can use "-o compress_extension=*". > Okay, great! This isn't mentioned in the documentation: compress_extension=%s Support adding specified extension, so that f2fs can enable compression on those corresponding files, e.g. if all files with '.ext' has high compression rate, we can set the '.ext' on compression extension list and enable compression on these file by default rather than to enable it via ioctl. For other files, we can still enable compression via ioctl.