Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1257548ybt; Tue, 7 Jul 2020 11:09:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXDgAG9m8UEeseQ3kbvBaPEkwG8PgspJLpLbRKrfwyng2tavoHDyN6Ag25qRylSw/MhbJg X-Received: by 2002:a05:6402:2c2:: with SMTP id b2mr62525906edx.184.1594145370223; Tue, 07 Jul 2020 11:09:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594145370; cv=none; d=google.com; s=arc-20160816; b=B3j4VBAG9nqQs9FeYDU4sp5z8xn2bjAHDZTtCk0pMfmGWBVbNANsxOPLnN93CAcqR3 OI7E06+CmppEHBvNOuwfBfOCzXtkOHQrMvMR2Q3JeQgpO1mijiR3k3V2pyWxbI27/MaX gVjJoV8iwO+Y6+PTna+gUT4JYokHkNWHN1x05HRjgdSz0yVBQcOJd8xThO9NKkDyz0OU lKZyocd/5S0jE3XK6EqTfXo/WNPHsEazypFdYYNeVNLHbQXcMqh9fZ/hIXcUAUdGEzYr JeOlxsiH6OnOP9/dn8i+wJ5iWtmIBxrUnHc0YvQ8pSg7CbG5gAnqrGzNTWFse+Yt0kmN p3yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4Q1VTZ4rp+/mA1dQ385M9WWX4yZQ0+d88IslrtxE41Y=; b=g4BXGyVQ8HUxfLcPMdHDW0GcqB/ayHT9X9E3lLkYK2OPTU+7UiAqEs8vedN35yS4I8 FjMGOgngK/H2woLPFKdZP6DWUtj861fT9ka+ru8FoLVJYd6eNhcxsw9ATnwuimrfTZwt dVZg9Aw2IEuLJTE0ZNNl7qMC8gYmyfn9y0VYCgnhgHkm2QxwFTHRehBQJ4Nz5kpqU1X1 38M8Oqbw9z9TqAjb8qW422gbCXipBYyEmyYuvBCbJxpH+pGNmvoB5q1mK5/hrFSMJdth lthA++lf9ZeXEop3+RyWj551plVwPo3kNZudwNlvbuPMFIs6ZhoML2gwmakGi0qt7Akg HCIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tcnxsJRq; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg8si15919014edb.184.2020.07.07.11.09.00; Tue, 07 Jul 2020 11:09:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tcnxsJRq; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728029AbgGGSI4 (ORCPT + 99 others); Tue, 7 Jul 2020 14:08:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:60606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727834AbgGGSI4 (ORCPT ); Tue, 7 Jul 2020 14:08:56 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8917E20708; Tue, 7 Jul 2020 18:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594145335; bh=296k3vE2kk+jFGLHJR3rGPowqbR7vIAKHN05TDFqEjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tcnxsJRqHw+W02Km31hpUvdQQVBZ3J18CWf6ryCBIr/V+IM1gdxhjl3eLzTZYSMgT MvODHFpSVX+Wwb0vQtNnfA2DuOghtogMd7IjxrhhrEH+I5FZjHbwJAAoDzTOcPraB2 h8r2enGEWKOpHzfobdAqJ29kADsewKrXCBoz5j9w= Date: Tue, 7 Jul 2020 11:08:54 -0700 From: Eric Biggers To: Satya Tangirala , Theodore Ts'o , Andreas Dilger Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org Subject: Re: [PATCH v4 0/4] Inline Encryption Support for fscrypt Message-ID: <20200707180854.GB839@sol.localdomain> References: <20200702015607.1215430-1-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702015607.1215430-1-satyat@google.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jul 02, 2020 at 01:56:03AM +0000, Satya Tangirala wrote: > This patch series adds support for Inline Encryption to fscrypt, f2fs > and ext4. It builds on the inline encryption support now present in > the block layer, and has been rebased on v5.8-rc3. Note that Patches 1 and > 2 can be applied independently of Patches 3 and 4 (and Patches 3 and 4 can > be applied independently of each other). > > This patch series previously went though a number of iterations as part > of the "Inline Encryption Support" patchset (last version was v13: > https://lkml.kernel.org/r/20200514003727.69001-1-satyat@google.com). > > Patch 1 introduces the SB_INLINECRYPT sb options, which filesystems > should set if they want to use blk-crypto for file content en/decryption. > > Patch 2 adds inline encryption support to fscrypt. To use inline > encryption with fscrypt, the filesystem must set the above mentioned > SB_INLINECRYPT sb option. When this option is set, the contents of > encrypted files will be en/decrypted using blk-crypto. > > Patches 3 and 4 wire up f2fs and ext4 respectively to fscrypt support for > inline encryption, and e.g ensure that bios are submitted with blocks > that not only are contiguous, but also have continuous DUNs. I've applied patches 1-3 to fscrypt.git#master for 5.9. Any additional reviews are still appreciated though. Ted and Andreas, can I get your Acked-by on patch 4? - Eric