Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ext2: initialize quota info in ext2_xattr_set()
To:     Chengguang Xu <cgxu519@mykernel.net>, jack@suse.com
Cc:     linux-ext4@vger.kernel.org
References: <20200626054959.114177-1-cgxu519@mykernel.net>
From:   Ritesh Harjani <riteshh@linux.ibm.com>
Date:   Wed, 8 Jul 2020 16:22:01 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200626054959.114177-1-cgxu519@mykernel.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <20200708105202.7AE73A405F@b06wcsmtp001.portsmouth.uk.ibm.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


On 6/26/20 11:19 AM, Chengguang Xu wrote:
> In order to correctly account/limit space usage, should initialize
> quota info before calling quota related functions.

How did you encounter the problem?
Any test case got hit?

> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>

LGTM, feel free to add
Reviewed-by: Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>


> ---
>   fs/ext2/xattr.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
> index 943cc469f42f..913e5c4921ec 100644
> --- a/fs/ext2/xattr.c
> +++ b/fs/ext2/xattr.c
> @@ -437,6 +437,9 @@ ext2_xattr_set(struct inode *inode, int name_index, const char *name,
>   	name_len = strlen(name);
>   	if (name_len > 255 || value_len > sb->s_blocksize)
>   		return -ERANGE;
> +	error = dquot_initialize(inode);
> +	if (error)
> +		return error;
>   	down_write(&EXT2_I(inode)->xattr_sem);
>   	if (EXT2_I(inode)->i_file_acl) {
>   		/* The inode already has an extended attribute block. */
>