Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp746113ybt; Wed, 8 Jul 2020 10:38:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzfsAdK5vwT7WgFDZXVdbwxM1Yi5OK4kUIYph9qEcACJfGNo5Nj5rmBwafP9zMQrTbbTvi X-Received: by 2002:a17:906:f101:: with SMTP id gv1mr47806621ejb.327.1594229913744; Wed, 08 Jul 2020 10:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594229913; cv=none; d=google.com; s=arc-20160816; b=hhXcwmVQVzy/5a8hE/9qjyB4hbUFG6WieXFC7eIMN1tBt7EbwxSwkh7tfyLljxsZNu iOKQr6Wzkd07JirxCWda5yeA/AK7KJebF/Py3ggYQPCo7bBMpHHo8agsdbKCCastLCRU 3ssc6jh+5yGa+whpwGY+QN+dlReO+kwKYzDeJunRtrq9quGbVE88uSZ2QIm2sm2OSXCp vr5yTKwrLx0r7wCwx2MGVFBHiGaZMBLx07SJ0H9ir4gjBIQuG+qYt8sOAtcMf0Kb6E41 0rd8StD2HDy3TCJZJ5CQAvYtP4B/sqKwkVJ5yr1a2tS2BGzLa/rSIZEfKShLCiSc3mCk JMsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ayBfljLvFMqbXkyr399Dq06k0B+LKcGGmBvZCgJVThY=; b=u2fO2Ad0gq1XKaH0m3S4g4R0mGDd5sONM8z2Y10lX1X3J+Y+IjojcDT8l7hs5G1XCN Tmlg4yQ+uWM/BaV3TPFwRhrZCP8n4S6p/zWv5DhXSXID1LuAnoh+CGvM8nlSzFnEiGaT t0H5AKMW7j8E8JdmT9Ko2KSgoXS3t1S/yXLcl3a0Pp2TFmF+uY7/MM0MKgb1XL1vcb2L Sryp66myj1MfIvxHnSonk4e+a4k3me7pS9SjbKaXZ8JPGwG2a45YdwiecrrKHeYEzVaM QVcMYhog1JujViV4ReK8uDziEia2mfkuKmnae5YzmnQQen5Z7bE/iI35v3xV3BNPo8x2 bhFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tjBbRT/b"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z10si313478ejc.59.2020.07.08.10.38.10; Wed, 08 Jul 2020 10:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tjBbRT/b"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbgGHRey (ORCPT + 99 others); Wed, 8 Jul 2020 13:34:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:45946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgGHRey (ORCPT ); Wed, 8 Jul 2020 13:34:54 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE22B206F6; Wed, 8 Jul 2020 17:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594229694; bh=n09ugl6WfqWNGruKtsGDgvdM0O8WqlobftThyJ0oyVo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tjBbRT/biosB1x+FYkug66Yhj2kJWisFl+iImfCbRhGlPgbns+b6Uh4j/OzMF/AKW VcfyCcgyvEWJ2cCIBonSl2YoUxIRw/2lRpkpreN+9TTP/QpLNM15VBmodOee2mP43J hW7JXhguxafrj1Ttet7Lj2FtiQQXTEqFd/WGYrGc= Date: Wed, 8 Jul 2020 10:34:52 -0700 From: Eric Biggers To: tytso@mit.edu Cc: Satya Tangirala , linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v4 4/4] ext4: add inline encryption support Message-ID: <20200708173452.GA32199@sol.localdomain> References: <20200702015607.1215430-1-satyat@google.com> <20200702015607.1215430-5-satyat@google.com> <20200708171812.GF1627842@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200708171812.GF1627842@mit.edu> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 08, 2020 at 01:18:12PM -0400, tytso@mit.edu wrote: > On Thu, Jul 02, 2020 at 01:56:07AM +0000, Satya Tangirala wrote: > > From: Eric Biggers > > > > Wire up ext4 to support inline encryption via the helper functions which > > fs/crypto/ now provides. This includes: > > > > - Adding a mount option 'inlinecrypt' which enables inline encryption > > on encrypted files where it can be used. > > > > - Setting the bio_crypt_ctx on bios that will be submitted to an > > inline-encrypted file. > > > > Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for > > this part, since ext4 sometimes uses ll_rw_block() on file data. > > > > - Not adding logically discontiguous data to bios that will be submitted > > to an inline-encrypted file. > > > > - Not doing filesystem-layer crypto on inline-encrypted files. > > > > Signed-off-by: Eric Biggers > > Co-developed-by: Satya Tangirala > > Signed-off-by: Satya Tangirala > > Reviewed-by: Theodore Ts'o > Thanks Ted. I've applied this patch to fscrypt.git#master for 5.9. - Eric