Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp746843ybt; Wed, 8 Jul 2020 10:39:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGvfuimARBk6TGHMSqyChnH8LXt1cWsdE/wuSw6ukfUqiW6AfW8PgYScQ8ScfHPzczNOW3 X-Received: by 2002:a17:907:2094:: with SMTP id pv20mr49866537ejb.512.1594229977093; Wed, 08 Jul 2020 10:39:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594229977; cv=none; d=google.com; s=arc-20160816; b=flgCL6/NAkeBQYAe3gqLez5VMFeOOTEHsQMk14eQ/h+XjX4/Kf0JeeMVLDj9JOE9XM ne95ACCvkfk3DCFwwlKHfIUhguBlSoQc/ZQuhXRqmsd5PQh23IBvIIexe/gkQFquGWAZ H+IgqY1HP9d5dgIl/p4PUMmHW3gGvM76x8nn/b773AtvsZiKTBTsqdiY1Xw945unkx7+ 2itPxENnSvpoW7jNxcHVhGd3FBZ4jDrqYsFe4nPnNWkDmglcZgX33A5X6OgqLOdulDdM ResFqRLjEWGSULg3SrEZeCjbwTkWcWg9WkayOF5zmQkcjNWxCWaEHpT9f52TIJ6XYMsY vmDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=h8Tar3PYJiYXBx8ugqdapOOuHbrWsgNFVfIxIZAvx6k=; b=yGxPy2UmF0ajEgg+CFX4B4nRmNY9UtMDBy7M/AthT5mT8gPcD2k+FQVy8RhVeVYomG UUISxZyRo5NIRmXeARXu5MMx0XDeCL6MIk1CQGPnbTCPc1zBthuE1GsCjmIh1PH5IBVg 7EaYUs/mopYQYxS+MPLyyWknepZa16UuEs1JQ4nv2IoCsPuV3U0O7tue9lPLT+7v6xWI q9yRyHs3n6nSctRwnkM0U5ol4OR8KIUvduaPVciVYu01rfyaUSbUDj8W9i1wgFlT8/mA ahadt4EbsrpmJLGV1Mja3IwoyRgW7ZrbyM3ZYKwY5K1mnGZlbhZJ5U49d8Ts9bs8x69F LQlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s2si303258ejx.162.2020.07.08.10.39.13; Wed, 08 Jul 2020 10:39:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726044AbgGHRSe (ORCPT + 99 others); Wed, 8 Jul 2020 13:18:34 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42294 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725787AbgGHRSe (ORCPT ); Wed, 8 Jul 2020 13:18:34 -0400 Received: from callcc.thunk.org (pool-96-230-252-158.bstnma.fios.verizon.net [96.230.252.158]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 068HIC0f023584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Jul 2020 13:18:13 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id B4682420304; Wed, 8 Jul 2020 13:18:12 -0400 (EDT) Date: Wed, 8 Jul 2020 13:18:12 -0400 From: tytso@mit.edu To: Satya Tangirala Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, Eric Biggers Subject: Re: [PATCH v4 4/4] ext4: add inline encryption support Message-ID: <20200708171812.GF1627842@mit.edu> References: <20200702015607.1215430-1-satyat@google.com> <20200702015607.1215430-5-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702015607.1215430-5-satyat@google.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jul 02, 2020 at 01:56:07AM +0000, Satya Tangirala wrote: > From: Eric Biggers > > Wire up ext4 to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encryption > on encrypted files where it can be used. > > - Setting the bio_crypt_ctx on bios that will be submitted to an > inline-encrypted file. > > Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for > this part, since ext4 sometimes uses ll_rw_block() on file data. > > - Not adding logically discontiguous data to bios that will be submitted > to an inline-encrypted file. > > - Not doing filesystem-layer crypto on inline-encrypted files. > > Signed-off-by: Eric Biggers > Co-developed-by: Satya Tangirala > Signed-off-by: Satya Tangirala Reviewed-by: Theodore Ts'o