Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1270823ybt; Thu, 9 Jul 2020 02:58:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJACZJQp+9HLMB7D6SUs2A8mhb3wr6AZ9QWxp4dP+4dAr0M9VCmP5GhUAQxHTh1LBpukK7 X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr73571015edr.138.1594288721635; Thu, 09 Jul 2020 02:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594288721; cv=none; d=google.com; s=arc-20160816; b=f41FT/XNIDpl3EjcqCHDgXe/daeK85JprAJ4gFl/BTqbRRG9MG8SDDf80a6Er7DMKY xr66Bspj3LBD6IJWl6UGGBjcGc/RKCu2MqmQECJfKit8Q48avMEXs23uv0lB+vI7R98d Ke3IT4UeI6Ct/w9EtRx9v0zqUeAuq6qC4JIlfYEha+cndMedzJfVK+FfYLQryMCjB6bs yE7Fw/iPQkph/1iKTrVHkTCPYFu6CgC91dp2bwJStLpqvIJDthIPFrH2skR+QpuJ4Hg2 72GtY/GMIgQ7oGHBAIjbePvggOuVcAVrBzREMluNj/YM1GkxOrYO3Cjz4U4bWPBaZ77C 45Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=9W6Zj+/yuqpbUolkRWTDF6dN56xC5uE+lfFsYF6H2sc=; b=OQhrdEHLQYUBvSyEwX+bll80CrwlXoiQYSpZstuhgl14uDNRlfur6Fr2C3CoIyQ1mP VpViufhxh40hgvlrpDhH3zqVQQJ1ob3MG/DD8ekMks7YD6Do/alHpapOK79UvpNtELZu y3Hs8I9ZwEsU7PnVWXNHntuQGh13q5bGO4dLZjbIwjAS/7qp0ITrAbwr2yFCTFWLpA/K cTlhVvUHwa1iGR99I1bwewvtfq9vDSn81FQBBd5hfuq63/Soq9Pip4QzIYN7AiJsfSC/ HZDvQpCSGWpRwtorTz81100U9qGwleS9vUAFM/3SXQ2J/8wfhayOYEKNEABqFl9ZAl6K eMAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si1452977ejs.278.2020.07.09.02.58.10; Thu, 09 Jul 2020 02:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726513AbgGIJ6A (ORCPT + 99 others); Thu, 9 Jul 2020 05:58:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:46604 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbgGIJ6A (ORCPT ); Thu, 9 Jul 2020 05:58:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 07FD9AC50; Thu, 9 Jul 2020 09:57:58 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 394811E12C5; Thu, 9 Jul 2020 11:57:58 +0200 (CEST) From: Jan Kara To: Cc: , Jan Kara Subject: [PATCH] generic/530: Require metadata journaling Date: Thu, 9 Jul 2020 11:57:53 +0200 Message-Id: <20200709095753.3514-1-jack@suse.cz> X-Mailer: git-send-email 2.16.4 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Test generic/530 doesn't make sence without metadata journalling as in that case, there's no way to recover shutdown fs besides fsck. ext4 can be configured without a journal and it supports shutdown ioctl even in that mode which makes this test fail for that configuration. Add requirement for metadata journalling to this test so that it's properly skipped. Signed-off-by: Jan Kara --- tests/generic/530 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/generic/530 b/tests/generic/530 index cb874ace902b..153a045dca87 100755 --- a/tests/generic/530 +++ b/tests/generic/530 @@ -33,6 +33,7 @@ _supported_fs generic _supported_os Linux _require_scratch _require_scratch_shutdown +_require_metadata_journaling _require_test_program "t_open_tmpfiles" rm -f $seqres.full -- 2.16.4