Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 9 Jul 2020 12:13:38 -0700
From:   "Darrick J. Wong" <darrick.wong@oracle.com>
To:     Jan Kara <jack@suse.cz>
Cc:     fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] generic/530: Require metadata journaling
Message-ID: <20200709191338.GA848607@magnolia>
References: <20200709095753.3514-1-jack@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200709095753.3514-1-jack@suse.cz>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 09, 2020 at 11:57:53AM +0200, Jan Kara wrote:
> Test generic/530 doesn't make sence without metadata journalling as in
> that case, there's no way to recover shutdown fs besides fsck. ext4
> can be configured without a journal and it supports shutdown ioctl even
> in that mode which makes this test fail for that configuration. Add
> requirement for metadata journalling to this test so that it's properly
> skipped.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>

<shudder> Right, I forgot about that...

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  tests/generic/530 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/530 b/tests/generic/530
> index cb874ace902b..153a045dca87 100755
> --- a/tests/generic/530
> +++ b/tests/generic/530
> @@ -33,6 +33,7 @@ _supported_fs generic
>  _supported_os Linux
>  _require_scratch
>  _require_scratch_shutdown
> +_require_metadata_journaling
>  _require_test_program "t_open_tmpfiles"
>  
>  rm -f $seqres.full
> -- 
> 2.16.4
>