Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ext2: initialize quota info in ext2_xattr_set()
To:     Ritesh Harjani <riteshh@linux.ibm.com>, jack@suse.com
Cc:     linux-ext4@vger.kernel.org
References: <20200626054959.114177-1-cgxu519@mykernel.net>
 <20200708105202.7AE73A405F@b06wcsmtp001.portsmouth.uk.ibm.com>
From:   Chengguang Xu <cgxu519@mykernel.net>
Message-ID: <38909abd-c180-8e04-216c-24755d1ca582@mykernel.net>
Date:   Sat, 11 Jul 2020 15:27:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200708105202.7AE73A405F@b06wcsmtp001.portsmouth.uk.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

=E5=9C=A8 7/8/2020 6:52 PM, Ritesh Harjani =E5=86=99=E9=81=93:
>
>
> On 6/26/20 11:19 AM, Chengguang Xu wrote:
>> In order to correctly account/limit space usage, should initialize
>> quota info before calling quota related functions.
>
> How did you encounter the problem?
> Any test case got hit?

I found the issue by code inspecting when I was learning mbcache logic.

Thanks,
cgxu

>
>>
>> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
>
> LGTM, feel free to add
> Reviewed-by: Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
>
>
>> ---
>> =C2=A0 fs/ext2/xattr.c | 3 +++
>> =C2=A0 1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
>> index 943cc469f42f..913e5c4921ec 100644
>> --- a/fs/ext2/xattr.c
>> +++ b/fs/ext2/xattr.c
>> @@ -437,6 +437,9 @@ ext2_xattr_set(struct inode *inode, int=20
>> name_index, const char *name,
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 name_len =3D strlen(name);
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (name_len > 255 || value_len > sb->s_b=
locksize)
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ERANGE;
>> +=C2=A0=C2=A0=C2=A0 error =3D dquot_initialize(inode);
>> +=C2=A0=C2=A0=C2=A0 if (error)
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return error;
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 down_write(&EXT2_I(inode)->xattr_sem);
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (EXT2_I(inode)->i_file_acl) {
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* The inode alre=
ady has an extended attribute block. */
>>