Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1632488ybh; Thu, 16 Jul 2020 18:36:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5Zy4aJ61XgBv6Gn16wyWERxpZGfuqTQZoAUR1ERAFCxFcqVNSibzhxvI7SO9LZCOAP05i X-Received: by 2002:a17:906:cecf:: with SMTP id si15mr6325721ejb.508.1594949766632; Thu, 16 Jul 2020 18:36:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594949766; cv=none; d=google.com; s=arc-20160816; b=IWzGiIbXEa8GzTsnL5vmTZTb1Xs8DLpxamE3U9CljOq5EochBZHHcV9tQEnzBR4G3H 9AGQ4WPWXF/9Wx8oJzz13uIjZwEdJT1hl5mOmX/BiDk181X5R4k0wxRtni0pYxxIgxb8 Bw9kt9mPqf0yyTKp7yUPo1xgVU162v97LHBEksWlMqXZzvZfWUdGTHqahbHlF1oHUhEa BwQBuNf3OhYsUIGb/NXpiuK9eRkahtS+NCMNAmiMl1JYKbWQOY0sXXmOkbzmZ7gNzORS t0kq6HpjOIrSBJsIrJkYaCo3MVD0EelVecFEyceXbkP5IYF6jwuYjqDunxGvDZnFpvT4 39ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=h180B5pNtOzbYEBjxwcBboRvZXlnjHO7g27S8UvB6u4=; b=st+HqYcE43mMxqhE8janI8iImIfaroML1jMGVYz0p7n7ICS8XfEnzVrok5MSEULdHq FbWAA753EnRXV5h7H7zu7cm2QcbZbArpRSY3hLiieMb2cqdsrTVZBfJDtWoKTXFVkJEG ABLRikXbSnGU8ANAJhoZo9K94hgQr7bTwUNQcMjxL2t5Ae75Dq8N1tmeH48OU4dUBJiW ujJQlo80j7ci3CthjhUqEe8/V+sbemq0ryKuW4pLsl/VTXUQ5ftI6G15t9zPH32FtHwu P8Tm8gNHUmjxnqeZK+5CJh+w8FD2hQQtsmehtiK3AiRzi7lTmL4qWTOUHk7f+ZzEOUZV Luwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ELjLl7Vq; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si4536421edr.390.2020.07.16.18.35.28; Thu, 16 Jul 2020 18:36:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ELjLl7Vq; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbgGQBf0 (ORCPT + 99 others); Thu, 16 Jul 2020 21:35:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbgGQBf0 (ORCPT ); Thu, 16 Jul 2020 21:35:26 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FDFCC08C5C0 for ; Thu, 16 Jul 2020 18:35:26 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id jx16so6664739pjb.6 for ; Thu, 16 Jul 2020 18:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=h180B5pNtOzbYEBjxwcBboRvZXlnjHO7g27S8UvB6u4=; b=ELjLl7Vq6Wv4yY35k8D7laIay5mUyA/mDCmNF9Y1UHm5Y/76WtJYAx/iugkyBLF7xL GPzIpQBTNRdUkcwnTw16m3C/jktVdbDVOzDbrKhs0XGRaNER0yp5a66lsqLyTMmDIqFJ BPQipZO3XktDJp/JrC6s4XmrPO+gGjjHsu5KQjaejvnFaUEEX9Luv8ycJFfHJMftrANR 6q5sXf1ZWpq/YRNvt4MytlDsV1dYyjoFmUbioMPgqjxclH836oYFThFc7cRj+fH9nAg1 PAwPX4vN/DarheFPwZnuT8LeMWDFGCnK/ZoXfa6SN8C6eFmmecCMrY3h9ezuXyQG/P5I s7qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=h180B5pNtOzbYEBjxwcBboRvZXlnjHO7g27S8UvB6u4=; b=oaLk4LvwiEf1Dn8dlK/R21QhtdqKnAzimCRVCeRvcrSAnw/o8Gh2l13gwDYGm4yeYw Rlm/2oAGJQ0ymUmdOTK00C9PCe5aGxAzzy8+m9zSM0bwzLBL6MdVZ7dCiOm3hMrmIgIh NJhVh6FROB36moespINnwHl/SBJFnr+FaZD5bjqdvCP/2zU6LaG3ajxz/0JIfyeSF2MJ oj/FJsQyq6Yr9OutaNeINr7W7MsCtcE6u8U9j386AbvXnvQ4XXTeSBy6WlH4zGzv7bhI 1zFfhuGdc/ZUqlS0xKBkFQIhKB9IKS9s/u6VpBPVR1YwhIE84egHQv+1R38v5wKKvt1K HIsQ== X-Gm-Message-State: AOAM533KB0kqhyuLbNZmISBSGq+H3ejOXNNJLLKITx27lhi0qbqnIJ9D enycTCYReJXWRXgXn37N2uCnKseGYYE= X-Received: by 2002:a17:902:c402:: with SMTP id k2mr5492580plk.185.1594949725585; Thu, 16 Jul 2020 18:35:25 -0700 (PDT) Date: Fri, 17 Jul 2020 01:35:11 +0000 Message-Id: <20200717013518.59219-1-satyat@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.rc0.105.gf9edc3c819-goog Subject: [PATCH v2 0/7] add support for direct I/O with fscrypt using blk-crypto From: Satya Tangirala To: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org Cc: linux-xfs@vger.kernel.org, Satya Tangirala Content-Type: text/plain; charset="UTF-8" Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This patch series adds support for direct I/O with fscrypt using blk-crypto. It has been rebased on fscrypt/master. Patch 1 adds two functions to fscrypt that need to be called to determine if direct I/O is supported for a request. Patches 2 and 3 wire up direct-io and iomap respectively with the functions introduced in Patch 1 and set bio crypt contexts on bios when appropriate by calling into fscrypt. Patches 4 and 5 allow ext4 and f2fs direct I/O to support fscrypt without falling back to buffered I/O. Patches 6 and 7 update the fscrypt documentation for inline encryption support and direct I/O. The documentation now notes the required conditions for inline encryption and direct I/O on encrypted files. This patch series was tested by running xfstests with test_dummy_encryption with and without the 'inlinecrypt' mount option, and there were no meaningful regressions. One regression was for generic/587 on ext4, but that test isn't compatible with test_dummy_encryption in the first place, and the test "incorrectly" passes without the 'inlinecrypt' mount option - a patch will be sent out to exclude that test when test_dummy_encryption is turned on with ext4 (like the other quota related tests that use user visible quota files). The other regression was for generic/252 on ext4, which does direct I/O with a buffer aligned to the block device's blocksize, but not necessarily aligned to the filesystem's block size, which direct I/O with fscrypt requires. Eric Biggers (5): fscrypt: Add functions for direct I/O support direct-io: add support for fscrypt using blk-crypto iomap: support direct I/O with fscrypt using blk-crypto ext4: support direct I/O with fscrypt using blk-crypto f2fs: support direct I/O with fscrypt using blk-crypto Satya Tangirala (2): fscrypt: document inline encryption support fscrypt: update documentation for direct I/O support Documentation/filesystems/fscrypt.rst | 36 +++++++++++- fs/crypto/crypto.c | 8 +++ fs/crypto/inline_crypt.c | 80 +++++++++++++++++++++++++++ fs/direct-io.c | 15 ++++- fs/ext4/file.c | 10 ++-- fs/f2fs/f2fs.h | 6 +- fs/iomap/direct-io.c | 8 +++ include/linux/fscrypt.h | 19 +++++++ 8 files changed, 173 insertions(+), 9 deletions(-) -- 2.28.0.rc0.105.gf9edc3c819-goog