Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/6] ext4: Check journal inode extents more carefully
To:     Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>
CC:     <linux-ext4@vger.kernel.org>, Lukas Czerner <lczerner@redhat.com>
References: <20200727114429.1478-1-jack@suse.cz>
 <20200727114429.1478-4-jack@suse.cz>
From:   luomeng <luomeng12@huawei.com>
Message-ID: <ec26732c-d219-8219-e7d6-63dab7aee03d@huawei.com>
Date:   Tue, 28 Jul 2020 17:10:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200727114429.1478-4-jack@suse.cz>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


?? 2020/7/27 19:44, Jan Kara д??:
> -int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk,
> +int ext4_inode_block_valid(struct inode *inode, ext4_fsblk_t start_blk,
>   			  unsigned int count)
>   {
>   	struct ext4_system_blocks *system_blks;
> @@ -344,8 +346,8 @@ int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk,
>   	 */
>   	rcu_read_lock();
>   	system_blks = rcu_dereference(sbi->system_blks);
Because of a change in the function parameters??there is no 'sbi' 
declared. So there will be a compile error:

   fs/ext4/block_validity.c: In function ??ext4_inode_block_valid??:
   fs/ext4/block_validity.c:345:32: error: ??sbi?? undeclared (first use 
        in this function)
   system_blks = rcu_dereference(sbi->system_blks);
> -	ret = ext4_data_block_valid_rcu(sbi, system_blks, start_blk,
> -					count);
> +	ret = ext4_data_block_valid_rcu(EXT4_SB(inode->i_sb), system_blks,
> +					start_blk, count, inode->i_ino);
>   	rcu_read_unlock();
>   	return ret;
>   }