Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp980522pxa; Wed, 5 Aug 2020 18:19:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPPDqpUXAHH82R2UJDPZ4UNFM0VftCmYDTcn1Sj7Ky91pwI/cAsIrbsIYwsr1XP1B3Gjt+ X-Received: by 2002:a50:b285:: with SMTP id p5mr1881093edd.139.1596676795810; Wed, 05 Aug 2020 18:19:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596676795; cv=none; d=google.com; s=arc-20160816; b=03ydUcbYfcgo0PMrZVAYa3af/lS3Pcv4MkjQHjhQOeowyeXSd3bUH+ECfI/d4UDzva lFCYkuB70DX6E3uYQky4/WQ7mHuStru8hoUZDKcKvFyVmE13m3YtUkrusaPLpYtgI4sL /SF2GarG7F+BMGBxmY6kDodt4GaNrcALRj84Kl96Sj0aiMJzaWlebunqqjbTT/XsVIy9 Cz1ROVPjk2w+L0s4iQH34vZ8YoRSxkIR8snPI4pDkR91pnVAaUjud8vnbxWqF7nX3qMu KMdopEztCydCa+kb2WdWj+YcUVXS+Iw5hB1BjH8Ki93G+/tBFRbQrM9wLa4vUnLfmgMj zyig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=olx/TZQLsWqMF/N1Ugy+KQrCN6RWoIERBHyR49ApepM=; b=Lg7CQnrSo3PGE0F/0IEQ0t9lRYzKNohLEY+eTYP+f1/jvcZPBfSZArVtwvZVi+4sjj ArCs26ZoiIo9LF719Ld7aQUT1RCii50gLVqXKjrjc3OGevjd4q0o7mb0U10Jhzrn5b6M x+6/ugqr53xLVe+JkZAafq4elJKtLoLIWCRRvlD/yzirdJdNMqAj2B88ROyrHPi0aSRo 03j5VL0Tfn4g9B64sXRaIlwX6Q109KL5eNcs0xvBcak8dJCQC4w39G799NHh5yPchXDO haaivRTyChKZ7P91RZZO6nDLqe2FMYLEaawyh9jFiVGEoXeVJJo55u8+xQELbhqQMtq2 jo2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=flZLcQ99; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cn16si2091929edb.505.2020.08.05.18.19.16; Wed, 05 Aug 2020 18:19:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=flZLcQ99; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725996AbgHFBTM (ORCPT + 99 others); Wed, 5 Aug 2020 21:19:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:40224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbgHFBTL (ORCPT ); Wed, 5 Aug 2020 21:19:11 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DD122245C; Thu, 6 Aug 2020 01:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596676750; bh=Q/nPyKFSTqrQ9nnopbWeCBGkmI0RyCRsimXLL0tW1mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=flZLcQ99Aj0xc2tl730AsZpuY1WF9t17S0WzyagItJtUU84hOLJCMBchIAdyVc2DD njfdx7bD4WYGC3CluvgMO1qkoAzYoQ/ngT3qmq+bC8doBFeKRuAbBqJG5K1oQYCunW iBnpbpOKAt7IzU5GIeCAbd6UA8xahL0n2dSWKrA8= Date: Wed, 5 Aug 2020 21:19:09 -0400 From: Sasha Levin To: Jan Kara Cc: stable@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, wanglong19@meituan.com, heguanjun@meituan.com, Jiang Ying Subject: Re: [PATCH v4] ext4: fix direct I/O read error Message-ID: <20200806011909.GD2975990@sasha-vm> References: <1596614241-178185-1-git-send-email-jiangying8582@126.com> <20200805085107.GC4117@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200805085107.GC4117@quack2.suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Aug 05, 2020 at 10:51:07AM +0200, Jan Kara wrote: >Note to stable tree maintainers (summary from the rather long changelog): >This is a non-upstream patch. It will not go upstream because the problem >there has been fixed by converting ext4 to use iomap infrastructure. >However that change is out of scope for stable kernels and this is a >minimal fix for the problem that has hit real-world applications so I think >it would be worth it to include the fix in stable trees. Thanks. How far back should it go? It breaks the build on 4.9 and 4.4 but the fix for the breakage is trivial. It does however suggest that this fix wasn't tested on 4.9 or 4.4, so I'd like to clarify it here before fixing it up (or dropping it). -- Thanks, Sasha