Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1083199pxa; Wed, 5 Aug 2020 22:07:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPDOySlXeLz3Vx4TO/OEul8OTcvANI1WNYNACkBfUB8aiHFUB2rO4CBKUkqrlbZN979qEN X-Received: by 2002:a50:93a2:: with SMTP id o31mr2443866eda.203.1596690443225; Wed, 05 Aug 2020 22:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596690443; cv=none; d=google.com; s=arc-20160816; b=wNQ70eZGZ2TQJ2haEPsMwUdd+ea8EixXadWLsfFB5f7Rh2ezoluscuBmdPAv6WnkEW 9sdRcC6O1NMlPGP9OZ/W2FBbZTWbLc9BJLdWmfZa0nCOuFeB9WJPsuX1oJ1VpWoExdhE B6wO09tDKUBEdHPSUcKxQWBeWbudgaALAioLHZ+5FP4Kt8ak2OdoPG4woupz/00qLN08 h9o9crbr/UFcLOs3oKFDdUxofjv1/5Qsi/AbCybmGCSxSsshGE3HulQApEN7yMI1Hp9p Yq3AER/PwNH1HbX+ng8NfcOvXquaDWXij7PT8oLsOTwn+g8u/z4cqBvIeF061qpHtKyT PQig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1amWcjwn4nED+02tOlnMu3O4YdRE8T5j8u3TyE8Kn1o=; b=aLCKBnc5F0gzdUvLsQeKw/PQh0fNB4ZnLyt8VmHYnFb4uqgeFTUtptVXLmBDTGkqZA yOnDoazpS6vjc6OzMRdnJpnO+Nsh7IVyVqGdcCfvspvvvSv9+lx1jEs5qKuTngA1FyIh e92kXxXY3qHh4Yczr42BH5OCm7lJrAhIuhwahevmjQ7NbIckR/FIwn0yScpLKFv6N694 MYuZmFg0wu7Hgs8s4owPGT1A/2H+1RJqq0rjp35zpNK2NuNDi7xlZevVYXaaYLZQaMQo Pp5Cz3BMI1+qwum/wAkOzfOGNu276wnC7oQwn32M8aOW5MK4abLo+Lvy37ThHaxIWj8K mL9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c12si2652702ejd.292.2020.08.05.22.06.54; Wed, 05 Aug 2020 22:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727790AbgHFExv (ORCPT + 99 others); Thu, 6 Aug 2020 00:53:51 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44711 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727118AbgHFExu (ORCPT ); Thu, 6 Aug 2020 00:53:50 -0400 Received: from callcc.thunk.org (pool-96-230-252-158.bstnma.fios.verizon.net [96.230.252.158]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0764rYov021458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Aug 2020 00:53:35 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id AF651420263; Thu, 6 Aug 2020 00:53:34 -0400 (EDT) Date: Thu, 6 Aug 2020 00:53:34 -0400 From: tytso@mit.edu To: zhengliang Cc: , Subject: Re: [PATCH v2] ext4: lost matching-pair of trace in ext4_truncate Message-ID: <20200806045334.GD7657@mit.edu> References: <20200701083027.45996-1-zhengliang6@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701083027.45996-1-zhengliang6@huawei.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 01, 2020 at 04:30:27PM +0800, zhengliang wrote: > It should call trace exit in all return path for ext4_truncate. > > v2: > It shoule call trace exit in all return path, and add "out_trace" label to avoid the > multiple copies of the cleanup code in each error case. > > Signed-off-by: zhengliang Thanks, applied. - Ted