Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1083258pxa; Wed, 5 Aug 2020 22:07:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpJau47i2Twl7XxIEk/Osq1mFusVa9Gimp0Zl6h2xV/AQ9Zh63TSALXkBLrCaB8VGIcrGd X-Received: by 2002:a17:906:c259:: with SMTP id bl25mr2553783ejb.303.1596690449788; Wed, 05 Aug 2020 22:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596690449; cv=none; d=google.com; s=arc-20160816; b=j7EQ13h5SdWMyRsSNk/zP79ESr2EI62Y6ykGD3SlU4yaAzHUwHFDguAxbEcxSeyi5O 7TIlvseGBiW7rBuchjir2knYlTyS8j0nHlQ7DT9r+vVVKRYYSl6TX9q1CzhxXT7PmWJk AuGHzpUTYD/7k9EN0dMIBFokTf9Ia/p6zJ9hOKhGReO32OHIFJ6UFgCJw1xJnFK0kK2Z IX5nCdS+/EtSDNm9ZIHzhLa7VtIs9/zuXE9HCgR3V2XOsvFX/dTinMILLDNI7u9qV2+i saVwfvKelwqb9i57pa5RY16RPzW3AJiz8w/XDzUDG+ueNWUaGLlpYOEFN9RtfZr0fF3O VyoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Cisx22NBqp9/An2v8Mb4xLwVEpavt8PrN8pIR2ZcCYo=; b=UDGV8JR78+AhnVqQWSWm+IKDeV2GTkL2EI+idhnpKG3ihpDeIpQrJheq9ICVVAeDLp 75Zz7dxxv9Qc8fPHjddYKsX5RNt9QwEIUF/mNiTrrwgvW/kpu4Qi6zHrVKBbhJOAGmSl PXjlOVTlQQzJbHFQn6xZeoq0DOPAPiHdAKm9C2KypZgoZpDVO+AI0G9INeEASmgW2Moi bEtwr3OiRowYSyLYovR5RFWoCaja+8pjNgZdfypyloKlP35M3sajE3arEy+Pnf6IZDQ6 XdWgatxEmOwO4enOierQLDhabRL2YKD/mDMsHvYqhxeAOatLN116lQaasji50Cd6FzDF 3lnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl8si2629320ejb.425.2020.08.05.22.07.06; Wed, 05 Aug 2020 22:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727864AbgHFFGT (ORCPT + 99 others); Thu, 6 Aug 2020 01:06:19 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45772 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725271AbgHFFGT (ORCPT ); Thu, 6 Aug 2020 01:06:19 -0400 Received: from callcc.thunk.org (pool-96-230-252-158.bstnma.fios.verizon.net [96.230.252.158]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 07656A55024162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Aug 2020 01:06:10 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 23BBB420263; Thu, 6 Aug 2020 01:06:10 -0400 (EDT) Date: Thu, 6 Aug 2020 01:06:10 -0400 From: tytso@mit.edu To: Jan Kara Cc: Subject: Re: [PATCH] ext4: Do not block RWF_NOWAIT dio write on unallocated space Message-ID: <20200806050610.GG7657@mit.edu> References: <20200708153516.9507-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200708153516.9507-1-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 08, 2020 at 05:35:16PM +0200, Jan Kara wrote: > Since commit 378f32bab371 ("ext4: introduce direct I/O write using iomap > infrastructure") we don't properly bail out of RWF_NOWAIT direct IO > write if underlying blocks are not allocated. Also > ext4_dio_write_checks() does not honor RWF_NOWAIT when re-acquiring > i_rwsem. Fix both issues. > > Fixes: 378f32bab371 ("ext4: introduce direct I/O write using iomap infrastructure") > Reported-by: Filipe Manana > Signed-off-by: Jan Kara Applied, thanks. - Ted