Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2287777pxa; Fri, 7 Aug 2020 07:43:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyj/KFNbnw5JJBtgbDy5vpad6jw55L16tcfZeSU1Ld44H0jd/H5MlFF00o8L8JaOIqORDoJ X-Received: by 2002:a17:907:42a0:: with SMTP id ny24mr9735197ejb.328.1596811386330; Fri, 07 Aug 2020 07:43:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596811386; cv=none; d=google.com; s=arc-20160816; b=B+l62bFT8RREj23fPLwfz2cC351yKo/x2KVUXF9hCkA1EFZsnO+wTcv2e2B8Xpi2/S tJKsg0/mRqfp/7KNvsd70Y7XODRItk7WQ1orYBmECbjWhsHovEhJzbFYCjetm9z2DAX2 wxCzEzywOpgXtI4kcWWtDz5GNutWFJYmRWfYtPiQHpB8MFK1YnNPl21WomdZiA6slNmR OgRaJ8wz84SUNCwEJrsOLqvUWPb9hi5Fcmjg5VlnooNHEs1HmhK4Ba85NsbjF9vcZEhg 0ggGH328yGeufpHCICF+iamzDDgwxPlrRDOkyQCCfC4VgvqXq+DlmbOLWcE1Rt1k5xIn sTig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Tj5MaKKd5wgvP3xQ9SxU6eabdBL22sd8KE2yM9k2gqA=; b=OfuHPWx9BrdInvsLoIyBERJtIHaOTXg4vgzRqoz9g8BdFqUTuwZ2tLqrwEGNGoFfYY UCxcv/0oU+wUvIjgfxHJdFvIE1H7qv79YRFFd7XAT1PJ2tn3xaVjfpcT7Cl2JNO8Mgn2 lCpp7UwDmwiAhZvsNgLfcuw7luNH6g0Ql3Z9Mlmiyi4OLxPZrSuVglHezxCQ5fTRftau JuP5YQocCav90YHEsg9LlyuKcbc3gpX1nN2/pc6hCno6Sqo70UO00l0h7hrx7p4FN58v AaADAwIpl1O0zmeJeI0Uz0FJZkoJlJ5RdWO4J90fjFM1QXQJEyvbPHSSRooGKu7m6QLQ 8rHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m8si5371220edp.351.2020.08.07.07.42.30; Fri, 07 Aug 2020 07:43:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726226AbgHGOmH (ORCPT + 99 others); Fri, 7 Aug 2020 10:42:07 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:33043 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725955AbgHGOmH (ORCPT ); Fri, 7 Aug 2020 10:42:07 -0400 Received: from callcc.thunk.org (pool-96-230-252-158.bstnma.fios.verizon.net [96.230.252.158]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 077EfsH8026551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 7 Aug 2020 10:41:55 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id A7E0A420263; Fri, 7 Aug 2020 10:41:54 -0400 (EDT) Date: Fri, 7 Aug 2020 10:41:54 -0400 From: tytso@mit.edu To: Lukas Czerner Cc: fstests@vger.kernel.org, guan@eryu.me, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2] ext4/002: Test read-only external journal device Message-ID: <20200807144154.GU7657@mit.edu> References: <20200717105544.3201-1-lczerner@redhat.com> <20200727102618.11695-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727102618.11695-1-lczerner@redhat.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jul 27, 2020 at 12:26:18PM +0200, Lukas Czerner wrote: > We should never be able to mount ext4 file system read-write with > read-only external journal device. Test it. > > This problem has been addressed with proposed kernel patch > https://lore.kernel.org/linux-ext4/20200717090605.2612-1-lczerner@redhat.com/ > > The test was based on generic/050. > > Signed-off-by: Lukas Czerner Looks good, tested with and without the fix. Reviewed-by: Theodore Ts'o - Ted