Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2432948pxa; Fri, 7 Aug 2020 11:00:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXC/3rEyw0sdwgfktSXS1X+RaHfFIhYEpUuBHnNEa/9f9icp2cuTbej/xWqgS1w+OlfidA X-Received: by 2002:a17:906:6406:: with SMTP id d6mr10181524ejm.30.1596823222469; Fri, 07 Aug 2020 11:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596823222; cv=none; d=google.com; s=arc-20160816; b=xqhOM3X4JWGYQpudImoB0DaSygbkPW8+cjAnbhCO2DyUK+XbWl2aZn4g1jlLrXG0x6 Hvv+ztF9Ee0bxj6vaGdwiIEjY0l8yb6sddh/S48kYuWHgd5K58fRox2HiczriexCX3Bb PD6OS/kXE7cupHkeWInDbd4tQVXxvaTEdhS4PZMB3QIr2CJKhcb+V1Nyb6rlNI2I2U4G 17eMAYBIv8L0QymVTnVEhlYG5MEK/SHvQRyjAwtOp922MTilyTGKiIy5PXb0jEaXf/VW hhKvpNb6RtkoS74jvrQw18YIOGUJdIF/bMHzfqHrx57tG2PPCfTLsvx2LGLrVqAhonNq y2cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/sbeUulmHpo/3dlgVCrqB5BbyarAY90eRt6ZIdHcsNQ=; b=s/H+W4KOfsBsDMQGeCCeatelRB1jXqBgPRfhHiLGQYwo81B32qWn8DG/b5lij3J1ud CC6J7uF1IVwjKUGjASMvr2rLYPzu6DtJz6bKZf632d2fxvhOW9P1mG1d+75GOHE7n1PY d8IDqlcehWczP+J3opNbiIMtv6NqA0CYcklAuNhQrMnswbJVSYwxPvB1GPeKbGJ3J1t6 1O5087HF2WXITrwITmU+m+yDVR7EfjU1TzxXiVGwuRQJN5kQEXcFOs5VNnoJ4eWbG6Fm LL2c3pXGEGdKK0f6seYvv1rFK64cIhJKLyZEpyzLa2IzzO9tBIZrb7SefJvWgoeTBCNy U8wQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x23si6589125edi.95.2020.08.07.10.59.58; Fri, 07 Aug 2020 11:00:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726095AbgHGR7m (ORCPT + 99 others); Fri, 7 Aug 2020 13:59:42 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39286 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725934AbgHGR7m (ORCPT ); Fri, 7 Aug 2020 13:59:42 -0400 Received: from callcc.thunk.org (pool-96-230-252-158.bstnma.fios.verizon.net [96.230.252.158]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 077HxOfg005715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 7 Aug 2020 13:59:25 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 86684420263; Fri, 7 Aug 2020 13:59:24 -0400 (EDT) Date: Fri, 7 Aug 2020 13:59:24 -0400 From: tytso@mit.edu To: "zhangyi (F)" Cc: , , , , Subject: Re: [PATCH v3 4/5] jbd2: abort journal if free a async write error metadata buffer Message-ID: <20200807175924.GX7657@mit.edu> References: <20200620025427.1756360-1-yi.zhang@huawei.com> <20200620025427.1756360-5-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200620025427.1756360-5-yi.zhang@huawei.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Jun 20, 2020 at 10:54:26AM +0800, zhangyi (F) wrote: > If we free a metadata buffer which has been failed to async write out > in the background, the jbd2 checkpoint procedure will not detect this > failure in jbd2_log_do_checkpoint(), so it may lead to filesystem > inconsistency after cleanup journal tail. This patch abort the journal > if free a buffer has write_io_error flag to prevent potential further > inconsistency. > > Signed-off-by: zhangyi (F) Thanks, applied. - Ted