Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <8A79C6DA-5C0F-4B4F-9EEE-E272993AD0FC@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_8ECA6D81-89C8-4F81-8EA4-7D1B55830A09";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] ext4: fix log printing of ext4_mb_regular_allocator()
Date:   Wed, 12 Aug 2020 13:36:08 -0600
In-Reply-To: <131a608b-0c8a-1a2d-57ee-4263cfcdd5a2@gmail.com>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     brookxu <brookxu.cn@gmail.com>
References: <131a608b-0c8a-1a2d-57ee-4263cfcdd5a2@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_8ECA6D81-89C8-4F81-8EA4-7D1B55830A09
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Aug 7, 2020, at 8:01 AM, brookxu <brookxu.cn@gmail.com> wrote:
>=20
> Fix log printing of ext4_mb_regular_allocator()=EF=BC=8Cit may be an
> unintentional behavior.
>=20
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

The debug message would probably be more useful if it included some
actual information (PID, status, fe_group, fe_start, fe_len), but
that isn't necessarily a problem with this patch itself.

Reviewed-by: Andreas Dilger <adilger@diger.ca>


> ---
> fs/ext4/mballoc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 5d4a1be..b0da525 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2324,15 +2324,14 @@ static int ext4_mb_good_group_nolock(struct =
ext4_allocation_context *ac,
> 		 * We've been searching too long. Let's try to allocate
> 		 * the best chunk we've found so far
> 		 */
> -
> 		ext4_mb_try_best_found(ac, &e4b);
> 		if (ac->ac_status !=3D AC_STATUS_FOUND) {
> 			/*
> 			 * Someone more lucky has already allocated it.
> 			 * The only thing we can do is just take first
> 			 * found block(s)
> -			printk(KERN_DEBUG "EXT4-fs: someone won our =
chunk\n");
> 			 */
> +			mb_debug(sb, "EXT4-fs: someone won our =
chunk\n");
> 			ac->ac_b_ex.fe_group =3D 0;
> 			ac->ac_b_ex.fe_start =3D 0;
> 			ac->ac_b_ex.fe_len =3D 0;
> --
> 1.8.3.1


Cheers, Andreas


--Apple-Mail=_8ECA6D81-89C8-4F81-8EA4-7D1B55830A09
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl80RKgACgkQcqXauRfM
H+CCPhAAlCchW92sNG3fhRqE5jqNi2Wl7sUe1mfZzMHj9xdpTTDhFtF9acusQYi0
CkVQovCazH+z2vWOM+2Vp3IrLaVk0QD4+4fd72zS5MamsSv7mnNe+Ku/a8LdUBcl
hkpRPdZiL5XxJ5FetkhgFABoX9Ab8b1zpbxUsmskX3nl4WkrE9POrcX/5o1YvDNE
U4+N6oDnhDWOG9WR/VZRIw+RQjjyPUKSKeeZWE0F7Cfdzmaja9zF7ca8svVy5xQI
ozytCbFFsqbaw9uyRHEZDEqEaC8ePE2HNX2zgWf6XyyGLZutnIYmySIVX6BF9pbH
+PbuzPin2PSEc419oiqxbAvx9uomGT56I3DyD0vmfsZ24+Z9V/jdhILtm1RFa2LG
E30s3bmu4hzpgGYmKOFlEsZjYTPWafP9y5UK2hykpsH/79zVJEhwqvmhBg2P9Zdd
0DrRwjWZ515dZgieOdLoa56c3X+R0OQig1ESIh1zpEN/SY1J0C/vVeDGZLL5/T39
MlPpzLZVwzOlFq6VMXV5SXlYCGhxucKjnZG1Ou8DQolDF2SEC9y3PizAA3mW5QTM
41fF/De9d52asdWtcCWwomeNxxUEQPjO/CZzRzRqMYICSCjhLS+7ceVq4XeQA0zY
P07Oo/Pa+TY5JKMbNxlfB+JvGqUDzJjslEO0oAMNDJRFibuEYFo=
=br5h
-----END PGP SIGNATURE-----

--Apple-Mail=_8ECA6D81-89C8-4F81-8EA4-7D1B55830A09--