Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] ext4: delete invalid ac_b_extent backup inside
 ext4_mb_use_best_found()
To:     Andreas Dilger <adilger@dilger.ca>, brookxu <brookxu.cn@gmail.com>
Cc:     "Theodore Ts'o" <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>
References: <0c77de22-c0d0-4c1b-645a-865bcd2edc0a@gmail.com>
 <B72B3282-4D45-41BB-8A39-66618C1CE69A@dilger.ca>
From:   Ritesh Harjani <riteshh@linux.ibm.com>
Date:   Thu, 13 Aug 2020 16:31:30 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <B72B3282-4D45-41BB-8A39-66618C1CE69A@dilger.ca>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <20200813110131.A1B794C05C@d06av22.portsmouth.uk.ibm.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


On 8/13/20 2:14 PM, Andreas Dilger wrote:
> On Aug 7, 2020, at 5:32 AM, brookxu <brookxu.cn@gmail.com> wrote:
>>
>> Delete invalid ac_b_extent backup inside ext4_mb_use_best_found(),
>> we have done this operation in ext4_mb_new_group_pa() and
>> ext4_mb_new_inode_pa().
> 
> I'm not sure I understand this patch completely.
> 
> The calls to ext4_mb_new_group_pa() and ext4_mb_new_inode_pa() are
> done from ext4_mb_new_preallocation(), which is called at the *end*
> of ext4_mb_use_best_found() (i.e. after the lines that are being
> deleted).
> 
> Maybe I'm confused by the description "we *have done* this operation"
> makes it seem like it was already done, but really it should be
> "we *will do* this operation in ..."?
> 
> That said, it would make more sense to keep the one line here in
> ext4_mb_use_best_found() and remove the two duplicate lines in
> ext4_mb_new_group_pa() and ext4_mb_new_inode_pa()?  In that case,
> the patch description would be more correct, like:
> 
>      Delete duplicate ac_b_extent backup in ext4_mb_new_group_pa()
>      and ext4_mb_new_inode_pa(), since we have done this operation
>      in ext4_mb_use_best_found() already.
> 

Looked into the mballoc code and I agree with Andreas points here.

-ritesh